Opened 17 years ago
Closed 16 years ago
#1917 closed Bug (fixed)
mergedown error / three cell
| Reported by: | Jaedeok Seol | Owned by: | Martin Kou |
|---|---|---|---|
| Priority: | Normal | Milestone: | FCKeditor 2.6.3 |
| Component: | General | Version: | SVN (FCKeditor) - Retired |
| Keywords: | Confirmed IE HasPatch Review+ | Cc: |
Description
two cell mergedown ok! three cell mergedown table broken.
Attachments (2)
Change History (13)
comment:1 Changed 17 years ago by
| Keywords: | Pending added |
|---|
comment:2 Changed 17 years ago by
| Keywords: | Confirmed IE added; Pending removed |
|---|
Confirmed.
To reproduce the bug, open sample01.html in IE.
- Make a 2x3 table which is the default.
- Right click on a cell in the top, choose cells, merge down.
- Right click on the merged cell, choose again cells, merge down.
- The table becomes broken.
Merging in Firefox works.
comment:3 Changed 17 years ago by
| Milestone: | → FCKeditor 2.7 |
|---|
Changed 16 years ago by
| Attachment: | fcktablehandler.js.patch added |
|---|
comment:7 Changed 16 years ago by
| Keywords: | HasPatch added |
|---|---|
| Milestone: | → FCKeditor 2.6.3 |
| Version: | → SVN |
comment:8 Changed 16 years ago by
| Owner: | set to Martin Kou |
|---|---|
| Status: | new → assigned |
comment:9 Changed 16 years ago by
| Keywords: | Review? added |
|---|
Lines 733 and 734 from Karena's patch isn't really needed because we're counting the rowSpan from the tableMap data structure, so we don't really have to add up the rowSpan of the current cell if we've already stored the sum in another variable.
Karena's patch has worked around an IE bug here though, which is the essential component of the fix. Our current code does not work in IE because we're depending on IE reporting the correct rowSpan for the td elements - unfortunately when a td is not attached to a tr IE would always report its rowSpan to be 1. So Karena's way of storing the sum in a variable works around the problem.
Proposing a new patch with lines 733 and 734 from Karena's patch removed.
Changed 16 years ago by
| Attachment: | 1917.patch added |
|---|
comment:10 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:11 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed with [2158].
Click here for more info about our SVN system.
Hi!
Could you please provide more detailed information about the bug? Also, could you please let us know what kind of browser and what version of FCKeditor are you using.
Thanks.