Opened 9 years ago

Closed 9 years ago

#2002 closed Bug (fixed)

Maximize editor button is broken

Reported by: Martin Kou Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Firefox Review+ Cc:

Description

Steps to reproduce:

  1. Open sample01.html in Firefox 2 or Firefox 3 beta.
  2. Type or paste something really long into the editing area so that the scroll bar appears.
  3. Press the maximize button.
  4. The editing area is not maximized vertically - the scrollbar is still at the previous height.

Attachments (2)

2002.patch (1.7 KB) - added by Martin Kou 9 years ago.
2002_2.patch (809 bytes) - added by Alfonso Martínez de Lizarrondo 9 years ago.
Additional modification

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by Wojciech Olchawa

In my case everything is fine in Firefox 2.0.0.12. The editing area is maximized.

comment:2 Changed 9 years ago by Wojciech Olchawa

Keywords: Confirmed Firefox added
Summary: Maximize editor button is broken in Firefox[FF3] Maximize editor button is broken

Confirmed using Firefox beta 2 and beta 3. Works with FF2.

comment:3 Changed 9 years ago by Frederico Caldeira Knabben

Confirmed with FF2 with the SVN code only. The online demo is ok.

comment:4 Changed 9 years ago by Frederico Caldeira Knabben

Summary: [FF3] Maximize editor button is brokenMaximize editor button is broken

comment:5 Changed 9 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

Changed 9 years ago by Martin Kou

Attachment: 2002.patch added

comment:6 Changed 9 years ago by Martin Kou

Keywords: Review? added

comment:7 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:8 Changed 9 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [1732].

Click here for more info about our SVN system.

Changed 9 years ago by Alfonso Martínez de Lizarrondo

Attachment: 2002_2.patch added

Additional modification

comment:9 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added; Review+ removed
Resolution: fixed
Status: closedreopened

I'm trying to update Write Area to the 2.6 code, and now I get a warning about e.originalTarget.ownerDocument being undefined in FF3b4, so this additional modification should take care of it.

comment:10 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:11 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: reopenedclosed

Fixed with [1771]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy