Opened 10 years ago

Closed 10 years ago

#2017 closed New Feature (fixed)

Make FCKeditorAPI.__Instances public

Reported by: Paul Moers Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

Put it in the docs and present it as a public thing so people can easily access every FCKeditor instance on the page.

E.g. (currenlty)

if (FCKeditorAPI)
{
	for (fckeditorName in FCKeditorAPI.__Instances)
	{
		if (FCKeditorAPI.GetInstance(fckeditorName).IsDirty())
		{
			changesMade = true;
			break;
		}
	}
}

Attachments (1)

2017.patch (2.6 KB) - added by Frederico Caldeira Knabben 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 2017.patch added

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added; FCKeditorAPI __Instances removed
Milestone: FCKeditor 2.6
Owner: set to Frederico Caldeira Knabben
Status: newassigned
Type: BugNew Feature

Even if __Instances is a private property, the proposed patch still defines it, as we know people is (wrongly) using it out there.

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review? added

comment:3 Changed 10 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:4 Changed 10 years ago by Paul Moers

Small remark:

The check for the FCKeditorAPI existence in my example should be:

if (window.FCKeditorAPI)

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [1713]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy