Opened 17 years ago
Closed 17 years ago
#2173 closed New Feature (fixed)
QuickUpload should show some info about the upload
| Reported by: | Alfonso Martínez de Lizarrondo | Owned by: | Alfonso Martínez de Lizarrondo |
|---|---|---|---|
| Priority: | Normal | Milestone: | FCKeditor 2.6.1 |
| Component: | General | Version: | FCKeditor 2.6 |
| Keywords: | Review+ | Cc: |
Description
When the user presses the Upload button, there's no indicator that something is happening.
Reusing the dialog's throbber seems like an easy solution.
Attachments (2)
Change History (7)
Changed 17 years ago by
| Attachment: | 2173.patch added |
|---|
comment:1 Changed 17 years ago by
| Keywords: | Review? added |
|---|---|
| Status: | new → assigned |
The change is basically allowing the throbber parent to remain in the DOM and then calling it from the dialogs as needed.
comment:2 Changed 17 years ago by
| Keywords: | Review- added; Review? removed |
|---|
There are two problems with the current implementation:
- If the user tries to upload two or more files via the upload tab, then the throbber bar would get longer with each upload. This is actually my fault, though. It happens because the Throbber object in fckdialog.html is designed to show the throbber once only (note that throbber bar is added by DOMNode.appendChild() in the Show() function).
- While the throbber is being shown on the dialog, the "OK" button and the tabs should be disabled.
comment:3 Changed 17 years ago by
| Keywords: | Review? added; Review- removed |
|---|
I've addressed both issues in the new patch.
comment:4 Changed 17 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:5 Changed 17 years ago by
| Milestone: | → FCKeditor 2.6.1 |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Fixed with [2043]
Note: See
TracTickets for help on using
tickets.
Proposed SVN patch