Opened 10 years ago

Closed 9 years ago

#2173 closed New Feature (fixed)

QuickUpload should show some info about the upload

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: FCKeditor 2.6.1
Component: General Version: FCKeditor 2.6
Keywords: Review+ Cc:

Description

When the user presses the Upload button, there's no indicator that something is happening.

Reusing the dialog's throbber seems like an easy solution.

Attachments (2)

2173.patch (3.1 KB) - added by Alfonso Martínez de Lizarrondo 10 years ago.
Proposed SVN patch
2173_2.patch (4.3 KB) - added by Alfonso Martínez de Lizarrondo 9 years ago.
Revised patch

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by Alfonso Martínez de Lizarrondo

Attachment: 2173.patch added

Proposed SVN patch

comment:1 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added
Status: newassigned

The change is basically allowing the throbber parent to remain in the DOM and then calling it from the dialogs as needed.

comment:2 Changed 9 years ago by Martin Kou

Keywords: Review- added; Review? removed

There are two problems with the current implementation:

  1. If the user tries to upload two or more files via the upload tab, then the throbber bar would get longer with each upload. This is actually my fault, though. It happens because the Throbber object in fckdialog.html is designed to show the throbber once only (note that throbber bar is added by DOMNode.appendChild() in the Show() function).
  2. While the throbber is being shown on the dialog, the "OK" button and the tabs should be disabled.

Changed 9 years ago by Alfonso Martínez de Lizarrondo

Attachment: 2173_2.patch added

Revised patch

comment:3 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added; Review- removed

I've addressed both issues in the new patch.

comment:4 Changed 9 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:5 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Milestone: FCKeditor 2.6.1
Resolution: fixed
Status: assignedclosed

Fixed with [2043]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy