Opened 17 years ago
Closed 17 years ago
#2184 closed Bug (fixed)
Lots of html validation errors in the filemanager
| Reported by: | Alfonso Martínez de Lizarrondo | Owned by: | Alfonso Martínez de Lizarrondo |
|---|---|---|---|
| Priority: | Normal | Milestone: | FCKeditor 2.6.1 |
| Component: | File Browser | Version: | FCKeditor 2.6 |
| Keywords: | Review+ | Cc: |
Description
I don't know why we didn't realize earlier, but the filemanager has lots of validations errors that can be solved (most of them) easily.
Attachments (1)
Change History (5)
Changed 17 years ago by
| Attachment: | 2184.patch added |
|---|
comment:1 Changed 17 years ago by
| Keywords: | Review? added |
|---|
The patch fixes most of the problems, except some warnings about framespacing, bordercolor and frameborder but they might be trickier to do them properly as the behavior of styles in the framesets sometimes isn't able to fully reproduce the same effects.
So I suggest to fix the main issues and then if someone wants to play with the frames try it, but meanwhile the rest of issues have been fixed.
comment:2 Changed 17 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
I would just change the "table.fullHeight" selector to ".fullHeight", just to make it more useful... it could be used elsewhere if needed.
We can leave with the framesets warnings for now, until we work on a File Browser review.
Fell free to make or not that CSS change and commit it directly.
comment:3 Changed 17 years ago by
| Milestone: | → FCKeditor 2.6.1 |
|---|
Proposed SVN patch