SHIFT+SPACE to insert  

[Frederico Caldeira Knabben]

Hitting SHIFT+SPACE should insert a   in the editor.

[Frederico Caldeira Knabben]

The provide patch currently works well with IE, Safari and Opera. For Firefox, it depends on #2248, so we should wait for it first, before a Review+.

[Martin Kou]

The patch works in IE correctly, but on Firefox Shift-Space is inserting two spaces.

[Frederico Caldeira Knabben]

Replying to martinkou:

on Firefox Shift-Space is inserting two spaces.

For me, it is inserting only one space. Is there any specific action to do to see the two spaces thing?

I'm testing with FF3 over Windows, but I remember having the same results with FF2.

[Martin Kou]

I've tested the patch again and it doesn't seem to be printing two spaces anymore. But now it's not always printing   after a few Shift-Space was pressed - some of the spaces are still regular spaces.

[Martin Kou]

Review-. There are a few more serious problems with this patch:

1. Firefox 2 and 3: If you press Shift-Space more than 4 times, than every other Shift-Space will produce a regular space and also will not move the caret forward.
2. Opera 9.50: Pressing Shift-Space produces line breaks instead of  s.

The patch is ok on IE and Safari.

[Martin Kou]

The fix to #2248 doesn't seem to work on FF3 now, but I've found a much simpler way to workaround Gecko's   bug. I've embedded the new fix in my patch and it seems to fix the problem.

[Frederico Caldeira Knabben]

We are almost there with the latest proposal. But, always with Firefox, the first space results in a plain space. So, if you press SHIFT+SPACE one, you get " "; twice you get "  "; more spaces get all properly outputted as " ".

The fact is that this feature will be mainly used with a single space when a user wants to separate text but break them together, like "USD 1,500".

[Martin Kou]

Hmm... this is tougher than it seems I'm afraid. I've tried various methods yesterday and today (e.g. trying your fix only for the first character, trying to modify the text node's value directly, etc.) but it always seems to go wrong by a little bit. I'm suspecting the Gecko developers are putting that space there on purpose to workaround something even more sinister.

[Martin Kou]

The real fix is quite tricky, but it seems to work ok.

[Frederico Caldeira Knabben]

How have 2247_3.patch​ reached the trunk with no review? I've reverted [2236] with [2276].

[Frederico Caldeira Knabben]

The 2247_3.patch looked too much tricky for me, and I still have raw spaces on some cases (like typing and adding spaces while typing).

I've worked on another clearer solution which also made the fix for #2248 simpler.

[Frederico Caldeira Knabben]

Fixed with [2279].

[Martin Kou]

The fix has caused bug #2412.