Opened 17 years ago
Closed 17 years ago
#2266 closed Task (fixed)
FCKeditor extension for MediaWiki doesn't follow MW's coding conventions
Reported by: | Jack Phoenix | Owned by: | |
---|---|---|---|
Priority: | Low | Milestone: | |
Component: | Project : MediaWiki+FCKeditor | Version: | SVN (FCKeditor) - Retired |
Keywords: | Confirmed HasPatch | Cc: |
Description
FCKeditor extension for MediaWiki doesn't seem to be following MediaWiki's coding conventions as described in http://www.mediawiki.org/wiki/Manual:Coding_conventions.
For example, FCKeditorEditPage.body.php had this in two separate lines:
class FCKeditorEditPage extends EditPage
{
when it should've been just one line as per MW's coding conventions:
class FCKeditorEditPage extends EditPage {
The extension credits ($wgExtensionCredits) in FCKeditor.php seem to be out-of-date and using "double quoting" (i.e. "name" => "FCKeditor", and so on) when 'single quoting' would be OK. I've created a patch against the current SVN version to fix these minor issues, let's see if I can attach it here... ;-)
Attachments (1)
Change History (3)
Changed 17 years ago by
Attachment: | FCKed.patch added |
---|
comment:1 Changed 17 years ago by
Keywords: | Confirmed HasPatch added |
---|---|
Priority: | Normal → Low |
This fortunately is a minor bug.
comment:2 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Thanks, fixed with [2077].
It's hard to follow strictly MediaWiki coding conventions, so let's just try to be constant and that should be enough. For javascript code, FCKeditor coding style is preferred: Coding Style Guidelines.
Patch to make the FCKeditor use standard coding style & updated $wgExtensionCredits with more accurate info