Empty/non-set FCK:editor value causes NullPointerException

[Michael Osipov]

A code like this:

<FCK:editor instanceName="EditorDefault">
  <jsp:attribute name="value"></jsp:attribute>
</FCK:editor>

or this

<FCK:editor instanceName="EditorDefault"  value=""/>

or this

<FCK:editor instanceName="EditorDefault"  />

Result in value being null and causing an NPE:

java.lang.NullPointerException
	at net.fckeditor.FCKeditor.createHtml(FCKeditor.java:238)
	at net.fckeditor.FCKeditor.toString(FCKeditor.java:223)
	at java.lang.String.valueOf(Unknown Source)
	at org.apache.jasper.runtime.JspWriterImpl.print(JspWriterImpl.java:584)
	at org.apache.jasper.runtime.JspWriterImpl.println(JspWriterImpl.java:689)
	at net.fckeditor.tags.EditorTag.doEndTag(EditorTag.java:138)
	at org.apache.jsp.jsp.sample02_jsp._jspx_meth_FCK_editor_0(org.apache.jsp.jsp.sample02_jsp:124)
	at org.apache.jsp.jsp.sample02_jsp._jspService(org.apache.jsp.jsp.sample02_jsp:93)
	at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:93)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
	at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:373)
	at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:470)
	at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:364)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
	at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
	at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:362)
	at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
	at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
	at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:729)
	at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
	at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:206)
	at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
	at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
	at org.mortbay.jetty.Server.handle(Server.java:324)
	at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
	at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:829)
	at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:513)
	at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
	at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
	at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:395)
	at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:488)

[Michael Osipov]

Bug verified in trunk

[Michael Osipov]

Fixed in [2227]

[Michael Osipov]

Merge patch to branch 2.4.x

[Michael Osipov]

Branch 2.4.x merged with trunk in [2538]