Opened 9 years ago

Closed 9 years ago

#2387 closed Bug (fixed)

FF: Bulleted list error with CTRL+A

Reported by: PavelZ Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6.3
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Firefox Review+ Cc:

Description (last modified by Frederico Caldeira Knabben)

Tested with Firefox/2.0.0.16, in the online demo.

With the following source:

<div>aaa</div>
<div>bbb</div>
<div>ccc</div>

In editing mode:

  1. select all (by pressing Ctrl+A)
  2. click "Insert/Remove Bulleted list"

A JS error is thrown and the first line of text is deleted.

Attachments (1)

2387.patch (1.2 KB) - added by Martin Kou 9 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by Frederico Caldeira Knabben

Description: modified (diff)
Keywords: Confirmed Firefox added
Milestone: FCKeditor 2.6.3
Summary: Bulleted list does not work properly in FFFF: Bulleted list error with CTRL+A
Version: SVN

Confirmed with FF3 also. Ok with IE7, Opera and Safari. It happens with the following source also:

<p>aaa</p>
<p>bbb</p>
<p>ccc</p>

This one causes lost of data, so I'm targeting it the the 2.6.3.

comment:2 Changed 9 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

comment:3 Changed 9 years ago by Martin Kou

Owner: Martin Kou deleted
Status: assignednew

This seems to be FCKDomRangeIterator's problem.

If I use the following code for testing:

<div id="1">aaa</div>
<div id="2">bbb</div>
<div id="3">ccc</div>

And then add the following code just before line 93 in editor/_source/commandclasses/fcklistcommands.js:

alert(block.id);

And then perform the bug's test case. You'll see the id of 1 appearing twice. The duplicated block leads to the JavaScript error later.

comment:4 Changed 9 years ago by Martin Kou

The bug is found to be caused by lines 138 and 139 in fckdomrangeiterator.js - but the two lines are used to workaround the bug #1717.

Changed 9 years ago by Martin Kou

Attachment: 2387.patch added

comment:5 Changed 9 years ago by Martin Kou

Keywords: Review? added

comment:6 Changed 9 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

comment:7 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:8 Changed 9 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [2274].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy