Opened 16 years ago
Closed 16 years ago
#2407 closed Bug (fixed)
Applying the div tool from the toolbar to a list screws the list up
Reported by: | Exception e | Owned by: | Martin Kou |
---|---|---|---|
Priority: | Normal | Milestone: | FCKeditor 2.6.4 |
Component: | General | Version: | FCKeditor 2.6.3 Beta |
Keywords: | Confirmed Review+ | Cc: |
Description
Applying the div tool from the toolbar to a list screws it up.
Type and select:
- foo
- bar
- roo
Then apply the div tool. Give it an inline style "border: 1px solid blue;".
Result:
paragraphs are added with contents of the li items. The list contains only spaces. The paragraphs are wrapped in the new div, but the list is outside the div.
tested both ie7 and firefox3
Attachments (2)
Change History (13)
comment:1 Changed 16 years ago by
Keywords: | Confirmed added |
---|
comment:2 Changed 16 years ago by
Owner: | set to Martin Kou |
---|---|
Status: | new → assigned |
Changed 16 years ago by
Attachment: | 2407.patch added |
---|
comment:3 Changed 16 years ago by
Keywords: | Review? added |
---|
comment:4 Changed 16 years ago by
Milestone: | FCKeditor 2.6.3 → FCKeditor 2.6.4 |
---|
The changes in the patch are too risky for a beta stabilization. I'm moving it to the next release.
comment:5 Changed 16 years ago by
But the buggy div tool is quite useless without this fix. Now blockquotes and divs are unreliable. Maybe it's an idea then to publish 2.6.4beta simultaneously.
comment:6 Changed 16 years ago by
If you need the fix urgently, you can download the source code of 2.6.3 from https://svn.fckeditor.net/FCKeditor/tags/2.6.3/ with an SVN client, apply the patch, and compile the code package with the _dev/build_release.bat file. You'll need a Windows machine with PHP installed to compile the package.
comment:7 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
This patch breaks the packaged files.
to fix it I've added a semicolon at the end of the noBlockLeft function:
var noBlockLeft = function( bqBlock ) { for ( var i = 0 ; i < bqBlock.childNodes.length ; i++ ) { if ( FCKListsLib.BlockElements[ bqBlock.childNodes[i].nodeName.toLowerCase() ] ) return false ; } return true ; } ;
Changed 16 years ago by
Attachment: | 2407_2.patch added |
---|
comment:9 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:10 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:11 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed with [2598].
Click here for more info about our SVN system.
Confirmed.
The bug also happens with the blockquote command.