Opened 11 years ago

Closed 10 years ago

#247 closed Bug (fixed)

IE : Delete all breaks EnterMode=div

Reported by: robmueller Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: UI : Enter Key Version: FCKeditor 2.4
Keywords: Confirmed IE Cc:

Description

Browser: IE 7.0.5730.11

EnterMode=div does not appear to have any effect on IE7, instead using EnterMode=p instead.

  1. Go to http://www.fckeditor.net/nightly/fckeditor/_samples/default.html and switch to the "Enter key behaviour" editor
  2. Switch "When [Enter] is pressed" to "Create new <div>"
  3. Type a<enter>b<enter>c<enter>
  4. Go to view source mode. Note that each letter is surrounded by <p>a</p>, no <div>'s in sight

Change History (4)

comment:1 Changed 11 years ago by Frederico Caldeira Knabben

Component: GeneralUI : Enter Key
Keywords: Confirmed IE added
Milestone: FCKeditor 2.4.1
Priority: HighNormal
Version: FCKeditor 2.4

Confirmed also with IE6.

comment:2 Changed 11 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.4.1FCKeditor 2.5
Summary: EnterMode=div does not work at all on IE7IE : Delete all breaks EnterMode=div

The thing is that it works well if you load sample12, place the cursor at the end of the text and then hit enter.

It will only break if you select all and delete it with the keyboard (backspace or delete). It works well when using the "New Page" buttons instead.

After further investigations, I found out that the problem here is that, on some cases, we are leaving the browser to make the delete job for us for the backspace and delete. In IE for example, when deleting everything, a <p> (and exclusively <p>) is automatically included by the browser.

So, it seams that the only solution is to handle all deletes with a custom implementation, overriding the browser defaults (as we do with the enter key). It means that FCKEnterKey.DoBackspace and FCKEnterKey.DoDelete must always return "true".

This is a big and complex change to the current code and I don't feel comfortable to do that right now, as a release is expected for the next week. We could consider working on it right after that release.

comment:3 Changed 10 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

comment:4 Changed 10 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [879].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy