Opened 11 years ago

Closed 10 years ago

#2653 closed Bug (fixed)

Changing table properties cannot be undone (undoes the previous action instead)

Reported by: thiloplanz Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: FCKeditor 2.6.4
Component: UI : Dialogs Version: FCKeditor 2.3.3
Keywords: Confirmed Review+ Cc:

Description

changing table properties does not insert an undo step. The result of this is that the change in properties cannot be undone. The previous action is undone instead.

The attached patch (fck_table.html) will always insert an undo step, which currently only happens when the table is initially created. This seems to fix the problem (the jury is still out on potential negative implications, but it looks safe).

Attachments (1)

fck_table.html.patch (704 bytes) - added by thiloplanz 11 years ago.
patch for fck_table.html (rev 2674)

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by thiloplanz

Attachment: fck_table.html.patch added

patch for fck_table.html (rev 2674)

comment:1 Changed 11 years ago by thiloplanz

Component: GeneralUI : Dialogs

comment:2 Changed 11 years ago by Artur Formella

Keywords: Confirmed HasPatch added; table undo removed
Version: FCKeditor 2.6.3FCKeditor 2.3.3

comment:3 Changed 10 years ago by thiloplanz

Changing table cell properties has the same problem, see #2733

comment:4 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added; HasPatch removed
Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

As both tickets are so similar I'm providing a single patch that includes both changes. It's just the fix proposed by thiloplanz for each one with a what's new entry.

comment:5 Changed 10 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:6 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Milestone: FCKeditor 2.6.4
Resolution: fixed
Status: assignedclosed

Fixed with [2861]. Thanks for the report and patch.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy