Opened 18 years ago
Closed 17 years ago
#27 closed Task (fixed)
The minimum integration requirements should be implemented
Reported by: | Frederico Caldeira Knabben | Owned by: | Thilo Schwarz |
---|---|---|---|
Priority: | Must have (possibly next milestone) | Milestone: | FCKeditor.Java 2.4 |
Component: | Server : Java | Version: | |
Keywords: | Cc: |
Description
The requirements defined at ServerSideStatus should be implemented.
Attachments (1)
Change History (11)
comment:1 Changed 17 years ago by
Priority: | Normal → High |
---|
comment:2 Changed 17 years ago by
Owner: | alka13 deleted |
---|
comment:3 follow-up: 4 Changed 17 years ago by
comment:4 Changed 17 years ago by
Replying to axmu:
I am inspecting the request for a "CreateHtml()" function, which is marked as not implemented in the Server Side integration Status page for Java. This seems to be redundant as the create() function is already providing this functionality - this java function does not write the result immediately to the page but returns an object containing the html for further use. Please let me know if I might be missing something here.
The problem here is the way the create() function has been implemented in the early beginning. It didn't follow the implementation present in other languages, where the HTML is automatically output when calling it. It instead does exactly what CreateHtml is supposed to do, returning the HTML string.
At this point, it would be difficult to fix it, by correcting the behavior of the create() function as it would definitively break things when upgrading. My proposal is renaming create() to createHtml(), making a new create() function which simply returns createHtml(). The create() function should be marked as deprecated at this point. In these way we'll be aligned with other implementations, opening a possibility to properly implement create() in the future.
Does it makes sense?
Changed 17 years ago by
Attachment: | FCKeditor.java added |
---|
comment:6 Changed 17 years ago by
I'm trying to create a SVN patch with your changes, but your file seems completely different. It seems that line breaks have been doubled. Also, JavaDoc comments have been changed (for worst, I mean). It is quite difficult to isolate your changes in a patch.
Do you think you are able to provide a SVN patch file, or even a diff file with the changes related to this ticket exclusively?
comment:7 Changed 17 years ago by
Owner: | set to Thilo Schwarz |
---|
comment:8 Changed 17 years ago by
Status: | new → assigned |
---|
comment:9 Changed 17 years ago by
Integration Status complete, documentation is handled by Ticket #1773
comment:10 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
I am inspecting the request for a "CreateHtml()" function, which is marked as not implemented in the Server Side integration Status page for Java. This seems to be redundant as the create() function is already providing this functionality - this java function does not write the result immediately to the page but returns an object containing the html for further use. Please let me know if I might be missing something here.
Axel