Opened 10 years ago

Closed 10 years ago

#2721 closed Bug (fixed)

Get rid of Parser_OldPP

Reported by: Etienne Massip Owned by: Sylvain
Priority: Must have (possibly next milestone) Milestone:
Component: Project : MediaWiki+FCKeditor Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Cc: brian.mingus, candrews@…, fwoelk@…, jsamuel@…, sbrohee@…

Description

Today, I've checked out MediaWiki 1.14 alpha and FCKEditor extension from their respective SVN repositories.

Added the following line at the end of MediaWiki's LocalSettings.php to enable extension :

require_once( "extensions/FCKeditor/FCKeditor.php" );

Then got an empty page and a two lines error in Apache error.log :

PHP Warning: require_once(D:
install
MediaWiki phase3/includes/parser/Parser_OldPP.php) [<a href='function.require-once'>function.require-once</a>]: failed to open stream: No such file or directory in D:
install
MediaWiki phase3
extensions
FCKEditor
FCKeditor.php on line 33, referer: http://localhost:88/index.php/Accueil

PHP Fatal error: require_once() [<a href='function.require'>function.require</a>]: Failed opening required 'D:
install
MediaWiki phase3/includes/parser/Parser_OldPP.php' (include_path='D:
install
MediaWiki phase3;D:
install
MediaWiki phase3/includes;D:
install
MediaWiki phase3/languages;.;C:
php5
pear') in D:
install
MediaWiki phase3
extensions
FCKEditor
FCKeditor.php on line 33, referer: http://localhost:88/index.php/Accueil

Line 33 in file FCKeditor.php just include Parser_OldPP.php :

...
if (version_compare("1.13alpha", $wgVersion, "<=")) {
    require_once $IP . "/includes/parser/ParserOptions.php";
    require_once $IP . "/includes/parser/Parser_OldPP.php";
    require_once dirname(__FILE__) . DIRECTORY_SEPARATOR . "mw12/FCKeditorParser_OldPP.body.php";
}
...

Well, the fact is that revision 43835 (dated from Nov, 21st) in MW's SVN just removed the file with comment "* Dropped old Paser_OldPP class. Only new parser with preprocessor is used. Death to the old parser! Long live the preprocessor!".

I guess the answer is that it is now time to move to new Parser.php ? What do you great people think ?

Attachments (1)

fckeditor_mediawiki_114alpha.zip (8.8 KB) - added by Etienne Massip 10 years ago.
Dumb quickfix

Download all attachments as: .zip

Change History (20)

comment:1 Changed 10 years ago by Etienne Massip

Cc: etienne.massip@… added
Keywords: old parser support removed

comment:2 Changed 10 years ago by Etienne Massip

Cc: etienne.massip@… removed

comment:3 Changed 10 years ago by Etienne Massip

See Revision data on mediawiki.org

comment:4 Changed 10 years ago by Artur Formella

Keywords: Confirmed added
Priority: NormalHigh

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.6.4

comment:6 Changed 10 years ago by brian.mingus

Cc: brian.mingus added

I spent a lot of time trying to fix this problem, but I am not a php developer and this involves the extensions to mediawiki's parser code which has been restructured.

Could someone who knows php spend a few minutes looking at the errors that arise and give us an estimate of how long it will take to fix? This would be greatly appreciated. My users are crying loudly :(

Thanks, Brian Mingus

comment:7 Changed 10 years ago by Seth Herd

This is broken for me as well, and I've had zero success fixing it myself. I loved fckeditor for mediawiki; I sure hope I can use it again...

comment:8 Changed 10 years ago by Etienne Massip

I quickfixed this myself the dirty way little time after I posted this and it works fine now; I'll attach the patch as soon as I'm back to work (on jan 5th) if nobody else already fixed it, but this is not a pretty fix.

Changed 10 years ago by Etienne Massip

Dumb quickfix

comment:9 Changed 10 years ago by Etienne Massip

This patch basically contains a copy of FCKeditorParser.body.php moved into mw12/ and completed with the old replace_callback() function.

Please notice that I didn't try it much at this time; also I'm not sure that every changes are necessary or done in a good way, or even smart, this is just a dumb quickfix that works in my own case.

Any feedback welcome !

comment:10 Changed 10 years ago by Craig

Cc: candrews@… added

comment:11 Changed 10 years ago by Craig

Any news?

comment:12 Changed 10 years ago by Etienne Massip

Nothing. Last commit in trunk is about 4 months old...is this project silently dying ? Hello ?

comment:13 Changed 10 years ago by jhfslkjdfaks

Cc: fwoelk@… added

comment:14 Changed 10 years ago by Joshua Samuel

Cc: jsamuel@… added

comment:15 Changed 10 years ago by Sylvain

Owner: set to Sylvain
Status: newassigned

I allowed myself to describe the great patch of emassip on the extension page of media wiki.

http://www.mediawiki.org/wiki/Extension:FCKeditor_(by_FCKeditor_and_Wikia)

Thanks a lot, it was very useful to me!

comment:16 Changed 10 years ago by Sylvain

Cc: sbrohee@… added

comment:17 Changed 10 years ago by Etienne Massip

There has been some code commited in repo a few minutes ago : r3177 !

comment:18 Changed 10 years ago by Wiktor Walc

Yes, fixed with [3177] :)

I've used the patch provided by emassip with one little change: instead of duplicating the code from FCKeditorParser_OldPP.body.php in FCKeditorParser.body.php, I've just recreated the missing Parser_OldPP class with the function that is needed (replace_callback).

This way we can still work on a single file (FCKeditorParser_OldPP.body.php) to fix other things.

comment:19 Changed 10 years ago by Wiktor Walc

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy