Opened 17 years ago

Last modified 15 years ago

#2767 review_failed Bug

plug-in:basicstyle AND elementpath incorrect style range detection — at Version 5

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone:
Component: Core : Styles Version: 3.0 Beta 2
Keywords: Confirmed Cc:

Description (last modified by Garry Yao)

Description

Style and element path detection on certain selection are incorrect.

Procedures

  1. Open an editor instance;
  2. Make selection as follow:
    <p> This is some <strong>sample ^text</strong>. You are using^ <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
    
    
  3. Check the Bold style status
  • Expected: style status should be off;
  • Actual: style status is on;

Test Cases

Test cases created with :

  1. Test select start partial in a bold style and end in non-style.
    • Original document:
      <p> level1<strong>le^vel2</strong>lev^el1</strong></p>
      
      
    • Reference results
      • FCKEditor2.6.3
        Bold style command status in on.
      • TinyMCE3.2.1
        Bold style command status in off, element path is body -> p.
    • Expected Result
      Bold style command status in off, element path is body -> p.
  2. Test select start partial in a bold style, select through non-style texts and end in bold style.
    • Original document:
      <p> level1<strong>le^vel2</strong>level1<strong>le^vel2</strong></strong></p>
      
      
    • Reference results
      • FCKEditor2.6.3
        Bold style command status in on.
      • TinyMCE3.2.1
        Bold style command status in off, element path is body -> p.
    • Expected Result
      Bold style command status in off, element path is body -> p.
  3. Test select start partial in a bold style which is in a td, selection goes through some other non-style text in cells, and end partial in a bold style in a td again.
    • Original document:
      <p>
      <table>
      	<tbody>
      		<tr>
      			<td><strong>c^ell1</strong></td>
      			<td>cell2</td>
      		</tr>
      		<tr>
      			<td>cell3</td>
      			<td><strong>cell^4</strong></td>
      		</tr>
      	</tbody>
      </table>
      </p>
      
      
  • Reference results
    • FCKEditor2.6.3
      Bold style command status in on'.
    • TinyMCE3.2.1
      Bold style command status in off, element path is body -> table -> tbody.
  • Expected Result
    Bold style command status in off, element path is body -> table -> tbody.

Change History (6)

comment:1 Changed 17 years ago by Artur Formella

Keywords: Confirmed added

comment:2 Changed 17 years ago by Garry Yao

Detailed range boundaries and elementpath dumped as below:

  1. Range boundaries:
    <p>This is some <strong>sample ^text</strong>. You are using^ <a _cke_saved_href="http://www.fckeditor.net/" href="http://www.fckeditor.net/">FCKeditor</a>.</p>
    
  2. Element path:
  • Expected: body -> p
  • Actual: body -> p -> strong

comment:3 in reply to:  2 Changed 16 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

Replying to garry.yao:

Detailed range boundaries and elementpath dumped as below:

  1. Range boundaries:
    <p>This is some <strong>sample ^text</strong>. You are using^ <a _cke_saved_href="http://www.fckeditor.net/" href="http://www.fckeditor.net/">FCKeditor</a>.</p>
    
  2. Element path:
  • Expected: body -> p
  • Actual: body -> p -> strong

comment:4 Changed 16 years ago by Garry Yao

Test cases created with :

  1. Test select start partial in a bold style and end in non-style.
    • Original document:
      <p> level1<strong>le^vel2</strong>lev^el1</strong></p>
      
      
  • Reference results
    • FCKEditor2.6.3
      Bold style command status in on, element path is p -> strong
    • TinyMCE3.2.1
      Bold style command status in off, element path is p
  • Expected Result
    Bold style command status in off, element path is p
  1. Test select start partial in a bold style, select through non-style texts and end in bold style.
    • Original document:
      <p> level1<strong>le^vel2</strong>level1<strong>le^vel2</strong></strong></p>
      
      
  • Reference results
    • FCKEditor2.6.3
      Bold style command status in on, element path is p -> strong
    • TinyMCE3.2.1
      Bold style command status in off, element path is p
  • Expected Result
    Bold style command status in off, element path is p

comment:5 Changed 16 years ago by Garry Yao

Description: modified (diff)
Summary: plug-in:basicstyle incorrect style range detectionplug-in:basicstyle AND elementpath incorrect style range detection

Changed 16 years ago by Garry Yao

Attachment: 2767.patch added
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy