Opened 11 years ago

Closed 11 years ago

#2792 closed Bug (fixed)

Remove default dialog values from the default configuration

Reported by: Frederico Caldeira Knabben Owned by: Artur Formella
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

Several of the dialog based plugins have been created with a standard "defaultValues" setting, which defines the default values to be used on dialogs.

The idea behind this is quite nice, as it makes it easy to set such values. This is a common request we have. But, the implementation took the easy way, which is not the best unfortunately.

The critical fact around this solution is that it makes our code bigger, and we must always keep in mind that our compressed code must be as small as possible.

But, we still need to support such customization. This is something Alfonso has described in #1099.

The nice thing is that it's already possible to do that by using our new API. Martin is working on a new sample for #2790, which will show how to do that.

So, we should remove this stuff from the configuration to benefit our code size.

Attachments (1)

2792.patch (24.0 KB) - added by Artur Formella 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by Artur Formella

Attachment: 2792.patch added

comment:1 Changed 11 years ago by Artur Formella

Keywords: Review? added

comment:2 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:3 Changed 11 years ago by Artur Formella

Resolution: fixed
Status: newclosed

Fixed with [3070]

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy