Opened 15 years ago

Last modified 15 years ago

#2799 closed Bug

V3: The skin file make specific dialog stuff by using the global CKEDITOR.dialog — at Version 2

Reported by: Frederico Caldeira Knabben Owned by: Garry Yao
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review- Cc:

Description (last modified by Garry Yao)

Into the default skin.js file, we can find references to CKEDITOR.dialog.setMargins and CKEDITOR.dialog.on( 'resize' ). This is bad, because it assumes that all editor instances are using a single skin, which is false.

All settings must go inside each single editor instance. Also, events like "resize" should be fired by each instance. The event could be named "dialogResize", for example.

Change History (3)

comment:1 Changed 15 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 15 years ago by Garry Yao

Description: modified (diff)

Depends on: #2802.

Changed 15 years ago by Garry Yao

Attachment: 2799.patch added
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy