Opened 16 years ago
Closed 16 years ago
#2916 closed Task (fixed)
Implement Flash dialog.
Reported by: | Martin Kou | Owned by: | Martin Kou |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | UI : Dialogs | Version: | SVN (FCKeditor) - Retired |
Keywords: | Review+ | Cc: |
Description
Need to port the Flash dialog from v2 to v3.
Attachments (2)
Change History (9)
comment:1 Changed 16 years ago by
Status: | new → assigned |
---|
Changed 16 years ago by
Attachment: | 2916.patch added |
---|
comment:2 Changed 16 years ago by
Keywords: | Review? added |
---|
comment:3 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
Changed 16 years ago by
Attachment: | 2916_2.patch added |
---|
comment:4 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:5 follow-up: 6 Changed 16 years ago by
The toLowerCase() function after scopeName is still there in the new patch. The reason being for namespaces other than HTML, IE would still always return in uppercase. Our source code has been assuming everything related to tags and namespaces are in lowercase, however. So I've kept the toLowerCase() there.
comment:6 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
Replying to martinkou:
The toLowerCase() function after scopeName is still there in the new patch. The reason being for namespaces other than HTML, IE would still always return in uppercase. Our source code has been assuming everything related to tags and namespaces are in lowercase, however. So I've kept the toLowerCase() there.
Good one... so, let's make the if comparison in uppercase, and move the toLowerCase function right after it, having:
var scopeName = this.$.scopeName; if ( scopeName != 'HTML' ) nodeName = scopeName.toLowerCase() + ':' + nodeName;
The getName function is a critical feature for our code.
Core stuff. I'm a bit stricter here:
I'll not go that deep on the dialog code. I'll be focused on checking the dialog usage instead.
Looks good for the rest.