Initial values for checkboxes are wrong

[Martin Kou]

To reproduce the bug:

1. Open replacebyclass.html in Firefox.
2. Open the link dialog.
3. Switch to target tab, and choose popup target. You should see 8 checkboxes which are not checked.
4. Cancel and close the link dialog.
5. Repeat step 3.
6. But this time, all the checkboxes are ticked, which is wrong.

[Martin Kou]

The bug was found to be due to the checkbox object constructor saving default value as an array instead of as a simply boolean value.

[Frederico Caldeira Knabben]

You may change the fix to the following and commit it directly:

!!elementDefinition.checked

[Martin Kou]

Fixed with [3068].

[Martin Kou]

Ok.. turns out we're having another problem now.

If one of the checkboxes in the link dialog has a default value set to true...

default : true

Then the first opening of the dialog would display that checkbox as checked, yet subsequent openings would display is as unchecked.

The cause of this bug is because of the checkbox UI element constructor is looking for the 'checked' attribute for the default value, yet other parts of the plugin assumes the attribute should be called 'default'.

[Garry Yao]

Fixed with [3054].

[Garry Yao]

Oops, make a mistake here, this ticket has nothing to do with [3054].

[Garry Yao]

Patch used for setup test

[Garry Yao]

A probably related bug would be set checked:true in checkbox definition doesn't work. Procedures, confirmed on FF3:

1. Setup by apply the test-checkbox-checked ;
2. Open _samples\api_dialog.html;
3. Open link dialog;
4. Found the checkbox is left as unchecked.

[Garry Yao]

Perhaps the patch doesn't handle the test case in comment:9, to take care the initial values, the override would result in something like:

			var overrides =
	            {
		            'default' :!!elementDefinition[ 'default' ]
	            };
	            if ( typeof elementDefinition.checked !== 'undefined' )
				overrides.initValue = !!elementDefinition.checked;

[Martin Kou]

Oh, actually I've discussed with Fred about that yesternight before submitting the patch. To make the checked attribute work, you'd have to override the initial value related functions in addition to the change you proposed, which increases code complexity without much benefit in return. So the checked attribute in checkbox element definition was to be changed to 'default' instead.

[Martin Kou]

Fixed with [3076].