Opened 10 years ago

Closed 10 years ago

#2931 closed Bug (fixed)

V3 : SpellChecker - WSC

Reported by: Artur Formella Owned by: Artur Formella
Priority: Normal Milestone: CKEditor 3.0
Component: UI : Spell Checker Version: SVN (FCKeditor) - Retired
Keywords: Review? Cc: WebSpellChecker.net

Description

New V3 plugin: Spell Check.

Attachments (3)

2931.patch (14.3 KB) - added by Artur Formella 10 years ago.
2931_2.patch (14.4 KB) - added by Artur Formella 10 years ago.
2931_3.patch (14.7 KB) - added by Artur Formella 10 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added

@arczi... attention with this one. In V2 we have three different spellcheckers. In V3, every single spellchecker will correspond to a plugin. So, to identify the spellchecker to use, you just change the plugin.

At first, we must support the WSC. Others may come later.

comment:2 Changed 10 years ago by Artur Formella

There is a syntax error in the spellchecker script ( http://loader.spellchecker.net/sproxy_fck/sproxy.php?plugin=fck2&cmd=script&doc=wsc&schema=22 )

            //@TODO: close session on ssrv

Only IE doesn't understand this code.

Changed 10 years ago by Artur Formella

Attachment: 2931.patch added

comment:3 Changed 10 years ago by Artur Formella

Keywords: Review? added

I really don't know why it works in IE in V2 but now it doesn't.

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Calling the plugin "wsc" is good, but it's not said that everything related to the plugin must get the plugin name. In this specific case, we are working on a spell checker and we can define "general rules" for all spell checkers:

  • The button should be named "SpellChecker".
  • The command name should be "checkspell".

Other than that, it's quite nice to see that the spell checking works in V3. I believe just some minor additions are needed.

I'll contact SpellChecker.net, so they can also have a look on this.

Changed 10 years ago by Artur Formella

Attachment: 2931_2.patch added

comment:5 in reply to:  4 Changed 10 years ago by Artur Formella

Keywords: Review? added; Review- removed
Summary: V3 : SpellCheckerV3 : SpellChecker - WSC

Replying to fredck:

  • The button should be named "SpellChecker".
  • The command name should be "checkspell".

Done.

IE "syntax error" bug still exists.

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Cc: WebSpellChecker.net added

Changed 10 years ago by Artur Formella

Attachment: 2931_3.patch added

comment:7 Changed 10 years ago by Artur Formella

Ok. Works in IE.

comment:8 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:9 Changed 10 years ago by Artur Formella

Resolution: fixed
Status: newclosed

Fixed with [3160]

comment:10 Changed 10 years ago by WebSpellChecker.net

Keywords: Review? added; Confirmed Review+ removed
Resolution: fixed
Status: closedreopened

It seems that during committing the patch to the trunk one file is missed:

_source/plugins/wsc/dialogs/ciframe.html

This can be found by reviewing patch content and changeset [3160]

Without this file spellchecker does not returns data back to the editor.

comment:11 Changed 10 years ago by Artur Formella

ciframe.html file was added with changeset [3219]

comment:12 Changed 10 years ago by Artur Formella

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy