Opened 11 years ago

Closed 11 years ago

#2945 closed Bug (fixed)

Editor instance intialization error

Reported by: Garry Yao Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Review+ Cc:

Description (last modified by Garry Yao)

The create editor on the fly APIs assume FORM always existed which is false. Reproducing procedures:

  1. Open _samples\api_dialog.html example.
  2. Got JavaScript Error in FF.

Attachments (2)

2945.patch (453 bytes) - added by Garry Yao 11 years ago.
2945_2.patch (547 bytes) - added by Frederico Caldeira Knabben 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by Garry Yao

Description: modified (diff)

Changed 11 years ago by Garry Yao

Attachment: 2945.patch added

comment:2 Changed 11 years ago by Garry Yao

Keywords: Review? added
Status: newassigned

comment:3 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Good catch. The fix could be a little different though. The fact is that the "form" variable must not exist if there is no form. It should not create the "empty" element objects.

I'm attaching a new patch to it.

Changed 11 years ago by Frederico Caldeira Knabben

Attachment: 2945_2.patch added

comment:4 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed
Owner: changed from Garry Yao to Frederico Caldeira Knabben
Status: assignednew

comment:5 Changed 11 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:6 Changed 11 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: newclosed

Fixed with [3094]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy