Opened 9 years ago

Closed 9 years ago

#2947 closed Bug (fixed)

Indent does not work in IE

Reported by: Frederico Caldeira Knabben Owned by: Martin Kou
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: 3.0 Beta
Keywords: Confirmed IE IBM Review+ Cc:

Description

The indentation button has no effect in IE. Works well with Firefox, Safari and Opera.

Attachments (2)

2947.patch (1.5 KB) - added by Martin Kou 9 years ago.
2947_2.patch (1.1 KB) - added by Martin Kou 9 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

Changed 9 years ago by Martin Kou

Attachment: 2947.patch added

comment:2 Changed 9 years ago by Martin Kou

Keywords: Review? added

comment:3 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The indent plugin code is correct. The code to be fixed is element::getAttribute.

Changed 9 years ago by Martin Kou

Attachment: 2947_2.patch added

comment:4 Changed 9 years ago by Martin Kou

Keywords: Review? added; Review- removed

comment:5 Changed 9 years ago by Garry Yao

The fix to element::getAttribute overlaps part of the patch of #2862.

comment:6 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

Please move the lowercase fix to the element class constructor, right after the _cke_saved_href check and go ahead committing.

comment:7 Changed 9 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [3100].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy