Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#2964 closed Bug (fixed)

plugin:image dialog loading cause JavaScript Error

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Review+ Cc:

Description

Procedures

  1. Open the replace by code example page in IE;
  2. Click image button to open dialog.
  • Actual Result : Encounter JavaScript error thrown.

Attachments (3)

2964.patch (785 bytes) - added by Garry Yao 8 years ago.
2964_2.patch (797 bytes) - added by Garry Yao 8 years ago.
Update with SVN
2964_3.patch (800 bytes) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (12)

Changed 8 years ago by Garry Yao

Attachment: 2964.patch added

comment:1 Changed 8 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 8 years ago by Martin Kou

Resolution: invalid
Status: assignedclosed

Hey, you forgot to update your local code copy. ;-)

That was fixed yesterday with [3096].

Changed 8 years ago by Garry Yao

Attachment: 2964_2.patch added

Update with SVN

comment:3 Changed 8 years ago by Garry Yao

Resolution: invalid
Status: closedreopened

Thanks for remind, but the fix of [3096] is incomplete though.

comment:4 Changed 8 years ago by Martin Kou

Keywords: Review?- added; Review? removed

Oh, yes, you're right. Fred's fix was incomplete.

But can you please change the this._.dialog line to this.getDialog()? Properties in _ are supposed to be "private". And the image plugin isn't too closely related to the dialog plugin to be reasonably given access to a dialog object's private variables.

comment:5 Changed 8 years ago by Martin Kou

Keywords: Review- added; Review?- removed

Changed 8 years ago by Garry Yao

Attachment: 2964_3.patch added

comment:6 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:7 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:8 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: reopenedclosed

comment:9 Changed 8 years ago by Garry Yao

Fixed with [3105]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy