#2964 closed Bug (fixed)
plugin:image dialog loading cause JavaScript Error
| Reported by: | Garry Yao | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | General | Version: | SVN (FCKeditor) - Retired |
| Keywords: | Confirmed Review+ | Cc: |
Description
Procedures
- Open the replace by code example page in IE;
- Click image button to open dialog.
- Actual Result : Encounter JavaScript error thrown.
Attachments (3)
Change History (12)
Changed 15 years ago by
| Attachment: | 2964.patch added |
|---|
comment:1 Changed 15 years ago by
| Keywords: | Review? added |
|---|---|
| Owner: | set to Garry Yao |
| Status: | new → assigned |
comment:2 Changed 15 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | assigned → closed |
comment:3 Changed 15 years ago by
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
Thanks for remind, but the fix of [3096] is incomplete though.
comment:4 Changed 15 years ago by
| Keywords: | Review?- added; Review? removed |
|---|
Oh, yes, you're right. Fred's fix was incomplete.
But can you please change the this._.dialog line to this.getDialog()? Properties in _ are supposed to be "private". And the image plugin isn't too closely related to the dialog plugin to be reasonably given access to a dialog object's private variables.
comment:5 Changed 15 years ago by
| Keywords: | Review- added; Review?- removed |
|---|
Changed 15 years ago by
| Attachment: | 2964_3.patch added |
|---|
comment:6 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:7 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:8 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Note: See
TracTickets for help on using
tickets.
Hey, you forgot to update your local code copy. ;-)
That was fixed yesterday with [3096].