Opened 11 years ago

Closed 11 years ago

#2971 closed New Feature (fixed)

Introduce the Format combo

Reported by: Frederico Caldeira Knabben Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

The Format combo is to be developed for V3.

Attachments (3)

2971.patch (60.4 KB) - added by Frederico Caldeira Knabben 11 years ago.
2971_2.patch (41.1 KB) - added by Frederico Caldeira Knabben 11 years ago.
2971_3.patch (67.3 KB) - added by Frederico Caldeira Knabben 11 years ago.

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by Frederico Caldeira Knabben

Attachment: 2971.patch added

comment:1 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review? added
Status: newassigned

Patch remarks:

  • I'm using iframe for the combo panel. That's the only way to make the items preview work well and give the WYSIWYG impression. The main difference is that, unlike V2, we have only one iframe created for all combos, in all editor instances into the page. So, the iframe overhead we have with V2 has been eliminated.
  • Even more... the iframe gets created only when needed. So, it has no impact on the editor creation performance.

Side notes:

  • Introduced CKEDITOR.tools.createClass, which probably should be our default way for creating classes. It makes the code more organized, introduce some tools and, mainly, makes instanceof work properly (by assign the function prototype to a literal object, we are breaking instanceof).
  • Introduce CKEDITOR.tools.addFunction and CKEDITOR.tools.addFunction, which makes it possible to include function calls on HTML events strings with less hacks.
  • Changed (fixed) the way UI elements are instantiated. Now we can safely use those elements in other places, like dialogs.

The following are known issues that should pass the review. I'll open tickets for them as soon as this one gets committed.

  • Safari: toolbar doesn't wrap.
  • Incorrect paragraph applied if the selection is at the very start or end of the paragraph.
  • IE: Items have been forced to black, otherwise they would be blue (default link color). It should have the contents.css color instead.
  • The combo panel position is a few pixels mispositioned (to left and top).
  • IE6: The combo panel has horizontal scrollbar.
  • No accessibility support yet.
  • The combo panel can go out of the viewport.
  • Firefox flickers the panel contents when opening it.
  • The special <pre> handling is not implemented.

comment:2 Changed 11 years ago by Martin Kou

Keywords: Review- added; Review? removed

Review- for the following reasons:

  1. There's no title attribute set on the combo box label, and as a result, "Output" is popped up when the mouse cursor hovers over it.
  2. The alpha filter in line 29 of richcombo.css is making the combo box label look very ugly in IE6. Recommend to add a line below line 29
    _filter: none;
    
    to fix it.

Changed 11 years ago by Frederico Caldeira Knabben

Attachment: 2971_2.patch added

comment:3 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed

Ok... the title has been reset for the entire editor now, at least on IE and FF.

The ugly IE6 thing was the ClearType bug. Fixed in the patch also.

Changed 11 years ago by Frederico Caldeira Knabben

Attachment: 2971_3.patch added

comment:4 Changed 11 years ago by Frederico Caldeira Knabben

The previous patch missed the added files. I've provided a new one. I've also updated it to the latest trunk.

comment:5 Changed 11 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:6 Changed 11 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [3113]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy