Opened 8 years ago

Closed 8 years ago

#3002 closed Bug (fixed)

Use "filters" for the htmlParser API

Reported by: Frederico Caldeira Knabben Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

Currently, we are introducing specific output manipulation directly into the domParser code. This makes that code quite hard to maintain, and less flexible, as it is not able to customize the manipulation with easy.

There should be instead a way to attach a "filter" to the parser, including all necessary rules for it.

In this the data processor can have a public filter property, which can be easily modified by a plugin or external code.

Attachments (1)

3002.patch (61.1 KB) - added by Frederico Caldeira Knabben 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Frederico Caldeira Knabben

Attachment: 3002.patch added

comment:1 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review? added
Status: newassigned

The provided patch introduces a quite drastic change in the way we manipulate data. It now parses it not only on output, but also on input (see #3003). Also, all the data transformation logic is now modular, so plugins can easily include their own filtering rules. The fakeobject system now uses it.

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

A good example of this code modularization is #3071.

comment:3 Changed 8 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [3172].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy