Safari 4 improperly sets height of editor area

[Michael Ney]

Tested on Safari 4 Windows and Webkit nightly build Mac. Issue occurs when pasting text or typing text.

To reproduce:

1. Open FCKEditor Demo page ​http://www.fckeditor.net/demo/toolbar?toolbar=Basic

2. Type or paste text into editor. Text will be 1 line too short to fill proper box size.

3. Resize Safari window. Editor area will suddenly expand to fill entire box.

Note 1: If it does not happen, try shift-reload first. It only happens on the first non-cached load of the page.

Note 2: Some editor layouts have no issues, some editor layouts have significant sizing issues, some over with the editor area 1 inch screen height too small.

See attached file for an extreme case.

[Michael Ney]

Sample screenshot of error in Windows Safari. Editor should be nearly entire height of screenshot.

[Joel Rosenberg]

See this thread for a similar problem with couple of workarounds - it could be useful

​http://www.fckeditor.net/forums/viewtopic.php?f=6&t=13222

[Alfonso Martínez de Lizarrondo]

#4157 has been marked as dup

[Alfonso Martínez de Lizarrondo]

Proposed patch

[Alfonso Martínez de Lizarrondo]

The patch basically changes the editor.html to allow the onresize to be called by both Firefox and Safari (note that the !Opera was useless as Gecko is defined as "gecko and !opera and !safari")

The two other changes to use the existence of window.onresize to call it instead of calling it only for gecko, and finally, I had to add a now manual call to window.onresize() in the fitscreen plugin because webkit didn't react to the change of dimensions.

Tested with Safari 4 in Mac and Windows and Chrome 2 in windows (remember to clear the cache on every test as these browsers really love their cache)

umm :-(

not ready for review yet. It doesn't work for example resizing the main window if the editor is maximized. (it sounded strange to me the need to manually call the code in the fitscreen code)

[Alfonso Martínez de Lizarrondo]

Proposed patch

[Alfonso Martínez de Lizarrondo]

Ok, this version is ready to be tested by anyone that cares. The problem in the first approach was that e.originalTarget doesn't exist (at least sometimes).

[Alfonso Martínez de Lizarrondo]

Fixed with [4223]