Ticket #3073 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Accessibility: Tab key toolbar navigation stop at Combo

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Review+ Cc:

Description (last modified by garry.yao) (diff)

It's now impossible to use Tab navigating through all the toolbar items caused by a stop at the the first combo button.

Attachments

3073.patch (5.2 KB) - added by garry.yao 5 years ago.
3073_2.patch (5.0 KB) - added by garry.yao 5 years ago.

Change History

comment:1 Changed 5 years ago by garry.yao

  • Description modified (diff)

comment:2 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Keywords Confirmed added
  • Status changed from new to assigned

Changed 5 years ago by garry.yao

comment:3 Changed 5 years ago by garry.yao

  • Keywords Review? added

The patch fixing the ComboButton and PanelButton so they are now accessible by Tab and other navigation keystrokes, 'Space' and 'Enter' keystrokes are customized, it will open the panel instead of performing commands.

comment:4 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed

It's nice to see that the keystrokes system for the toolbar are so easy to handle.

The patch is almost good. There is just one minor thing... the "hidefocus=true" attribute should not have been removed from "richcombo/plugin.js" line 123, as it fixes a small rendering issue with IE. It's ok for the rest.

Changed 5 years ago by garry.yao

comment:5 Changed 5 years ago by garry.yao

  • Keywords Review? added; Review- removed

comment:6 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:7 Changed 5 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [3175]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy