Opened 9 years ago

Closed 9 years ago

#3073 closed Bug (fixed)

Accessibility: Tab key toolbar navigation stop at Combo

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Review+ Cc:

Description (last modified by Garry Yao)

It's now impossible to use Tab navigating through all the toolbar items caused by a stop at the the first combo button.

Attachments (2)

3073.patch (5.2 KB) - added by Garry Yao 9 years ago.
3073_2.patch (5.0 KB) - added by Garry Yao 9 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by Garry Yao

Description: modified (diff)

comment:2 Changed 9 years ago by Garry Yao

Keywords: Confirmed added
Owner: set to Garry Yao
Status: newassigned

Changed 9 years ago by Garry Yao

Attachment: 3073.patch added

comment:3 Changed 9 years ago by Garry Yao

Keywords: Review? added

The patch fixing the ComboButton and PanelButton so they are now accessible by Tab and other navigation keystrokes, 'Space' and 'Enter' keystrokes are customized, it will open the panel instead of performing commands.

comment:4 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

It's nice to see that the keystrokes system for the toolbar are so easy to handle.

The patch is almost good. There is just one minor thing... the "hidefocus=true" attribute should not have been removed from "richcombo/plugin.js" line 123, as it fixes a small rendering issue with IE. It's ok for the rest.

Changed 9 years ago by Garry Yao

Attachment: 3073_2.patch added

comment:5 Changed 9 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:6 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 9 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3175]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy