Opened 9 years ago

Closed 5 years ago

#3105 closed Bug (invalid)

insertHtml and insertElement should agree on the result

Reported by: Garry Yao Owned by:
Priority: Normal Milestone:
Component: General Version: 3.0 Beta 2
Keywords: IE Webkit Cc:

Description (last modified by Garry Yao)

Currently CKEDITOR.editor.insertHtml and CKEDITOR.editor.insertElement are having different results when the inserted element happened to be malformed or schema-violated.
This is because insertHtml is depending some native methods like pasteHtml to perform revision, from which the result may vary from browser to browser. While insertElement is all about our own logic, which perform no revision at all( The revision logic is proposing at #3100 though).

Attachments (1)

test-insertHtml.2.patch (5.4 KB) - added by Garry Yao 9 years ago.
Functional Test Case

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by Garry Yao

Description: modified (diff)
Keywords: IE Webkit added

The attached test case's result are different from FF to IE to Webkit.

Changed 9 years ago by Garry Yao

Attachment: test-insertHtml.2.patch added

Functional Test Case

comment:2 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.0CKEditor 3.x

comment:3 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Version: SVN (FCKeditor)CKEditor 3.0 Beta 2

comment:4 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

comment:5 Changed 5 years ago by Piotrek Koszuliński

Resolution: invalid
Status: newclosed

Over the years meaning of these methods changed. Currently both are implemented using only our custom code, but insertHtml is more "external" (it does clean up and filtering) when insertElement is an "internal" method (I do not mean that it is private, but that it does not handle input, invalid data).

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy