Opened 8 years ago

Closed 8 years ago

#3120 closed Bug (fixed)

# (pound sign) is not correctly escaped in file urls

Reported by: Michael Osipov Owned by: Michael Osipov
Priority: Must have (possibly next milestone) Milestone: FCKeditor 2.6.5
Component: File Browser Version: FCKeditor 2.6.4
Keywords: HasPatch Review+ Cc:

Description (last modified by Michael Osipov)

File and folder names containing # are not correctly escaped.

The problematic spot is frmresourceslist.html, line 92:

window.top.opener.SetUrl( encodeURI( fileUrl ).replace( '#', '%23' ) ) ;

The replace function replaces at most one pound sign. Files won't get encoded correctly and are not accessible through the file browser.

I have attached a patch which works. This should make into 2.6.5.

An alternative would be to sanitize the character.

Attachments (1)

3120.patch (453 bytes) - added by Michael Osipov 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by Michael Osipov

Attachment: 3120.patch added

comment:1 Changed 8 years ago by Michael Osipov

Description: modified (diff)

comment:2 Changed 8 years ago by Michael Osipov

Description: modified (diff)

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Owner: set to Michael Osipov

comment:5 Changed 8 years ago by Michael Osipov

Milestone: FCKeditor 2.6.5
Resolution: fixed
Status: newclosed

Fixed with [3272].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy