Ticket #3120 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

# (pound sign) is not correctly escaped in file urls

Reported by: mosipov Owned by: mosipov
Priority: High Milestone: FCKeditor 2.6.5
Component: File Browser Version: FCKeditor 2.6.4
Keywords: HasPatch Review+ Cc:

Description (last modified by mosipov) (diff)

File and folder names containing # are not correctly escaped.

The problematic spot is frmresourceslist.html, line 92:

window.top.opener.SetUrl( encodeURI( fileUrl ).replace( '#', '%23' ) ) ;

The replace function replaces at most one pound sign. Files won't get encoded correctly and are not accessible through the file browser.

I have attached a patch which works. This should make into 2.6.5.

An alternative would be to sanitize the character.

Attachments

3120.patch (453 bytes) - added by mosipov 5 years ago.

Change History

Changed 5 years ago by mosipov

comment:1 Changed 5 years ago by mosipov

  • Description modified (diff)

comment:2 Changed 5 years ago by mosipov

  • Description modified (diff)

comment:3 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:4 Changed 5 years ago by fredck

  • Owner set to mosipov

comment:5 Changed 5 years ago by mosipov

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone set to FCKeditor 2.6.5

Fixed with [3272].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy