Opened 9 years ago

Closed 9 years ago

#3126 closed Task (fixed)

Rename documentFragment.js to lower case

Reported by: Frederico Caldeira Knabben Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review- Cc:

Description

The documentFragment file has been mistakenly named with camel case, just like the class name. It must instead be renamed to full lowercase.

The reference in loader.js is also to be renamed, as well as the test file for it.

Attachments (2)

3126_part1.patch (9.0 KB) - added by Artur Formella 9 years ago.
3126_part2.patch (10.8 KB) - added by Artur Formella 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by Artur Formella

Attachment: 3126_part1.patch added

Changed 9 years ago by Artur Formella

Attachment: 3126_part2.patch added

comment:1 Changed 9 years ago by Artur Formella

Keywords: Review? added
Owner: set to Artur Formella
Status: newassigned

comment:2 Changed 9 years ago by Artur Formella

Both patches are needed to rename those files

comment:3 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
Owner: changed from Artur Formella to Frederico Caldeira Knabben
Status: assignednew

Doing that in this way makes we loose the file log. This must be done in another way, and patches can't be used for that.

I'll do that here directly, as there is no way to get a proper review of it. It's such a small issue that it will should not bring negative consequences.

comment:4 Changed 9 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: newclosed

Fixed with [3263], [3264] and [3265].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy