Opened 11 years ago

Closed 10 years ago

#3138 closed Bug (fixed)

Request for multi-language files for CKEditor 3.0

Reported by: Senthil Owned by: Wiktor Walc
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: Oracle Confirmed Review+ Cc: Senthil

Description

Request for multi-language files for all the features available in CKEditor 3.0

Attachments (2)

3138.patch (973.2 KB) - added by Wiktor Walc 10 years ago.
3138_2.patch (971.1 KB) - added by Wiktor Walc 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Priority: NormalHigh
Status: newassigned

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added
Owner: changed from Frederico Caldeira Knabben to Wiktor Walc
Status: assignednew

Changed 10 years ago by Wiktor Walc

Attachment: 3138.patch added

comment:3 Changed 10 years ago by Wiktor Walc

Keywords: Review? added

In the wsc plugin the "toolbar" property has never been used, so I assumed that the intention was to use this string in the SpellChecker button.

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

It's really nice to see that you were able to move the translations from V2. It works pretty well.

I've found a few issues though.

  • The "Anchor Properties" dialog title is wrongly translated to "Button Properties".
  • For font and fontSize, please use the same value used for "label" in "panelTitle".

Then, there are some encoding issues, and I'm afraid those are related to TortoiseSVN, not being able to apply the patch properly:

  • Accented characters are not being displayed properly. I've fixed it by saving the file in UTF-8 with BOM.
  • The Arabic language file, for example, have "?" for every arabic char.

So, if you are totally sure these two things are ok for you, don't worry about it. It will be ok when you commit it.

Changed 10 years ago by Wiktor Walc

Attachment: 3138_2.patch added

comment:5 Changed 10 years ago by Wiktor Walc

Keywords: Review? added; Review- removed

I did have the same problem when applying this patch with TortoiseSVN (created with TortoiseSVN on the same computer btw.), however there are no problems when using the commandline "patch" command.

Changes vs previous patch:

  • font, fontSize and format are using value for "label" in "panelTitle"
  • corrected invalid "Anchor Properties" translation.

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 10 years ago by Wiktor Walc

Resolution: fixed
Status: newclosed

Fixed with [3282], translation status added with [3283].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy