Insert link incorrect within table cell

[Garry Yao]

Reproducing Procedures

1. Open the replace by code example page;
2. Make document content and selection as following by double click on cell:

   <table>
   	<tbody>
   		<tr>
   			<td>^
   				text^</td>
   		</tr>
   	</tbody>
   </table>
   

   1. Open link dialog to insert a default link.
   • Actual Result : The link is not inserted at all.

Additional information: This is actually a style system bug. The same thing happens if you press the bold button or try to apply any inline style with the HTML and selection above.

[Garry Yao]

Same thing happens for list items.

Reproducing Procedures

1. Open the replace by code example page;
2. Make document content and selection as following by double click on secondary list item:

   <ol>
   	<li>
   		level1</li>
   	<li>
   		^leve1^</li>
   </ol>
   

   1. Open link dialog to insert a default link.
   • Actual Result : The link is not inserted at all.

[Frederico Caldeira Knabben]

WFM with the table case, but it is buggy with the list example.

[Martin Kou]

The problem actually lies in the style system, in the applyInlineStyle() function. You can see the same bug with the same HTML and the same selection by pressing the bold button - nothing happens.

What happened in the applyInlineStyle() function is that the calculation of firstNode and lastNode in line 280, 281 is wrong. The lastNode calculated from there actually comes before the firstNode (you can verify by printing out their getAddress() output). We already have a more well tested way in CKEDITOR.dom.range::getBoundaryNodes() to do the same thing, so that function should be used instead.

[Frederico Caldeira Knabben]

Please remove the lastParent.type == CKEDITOR.NODE_ELEMENT check, as getParent will only return element type objects.

[Martin Kou]

Fixed with [3274] and [3275].

Click here for more info about our SVN system.