Changes between Initial Version and Version 4 of Ticket #3146


Ignore:
Timestamp:
Mar 23, 2009, 10:04:39 AM (15 years ago)
Author:
Martin Kou
Comment:

The problem actually lies in the style system, in the applyInlineStyle() function. You can see the same bug with the same HTML and the same selection by pressing the bold button - nothing happens.

What happened in the applyInlineStyle() function is that the calculation of firstNode and lastNode in line 280, 281 is wrong. The lastNode calculated from there actually comes before the firstNode (you can verify by printing out their getAddress() output). We already have a more well tested way in CKEDITOR.dom.range::getBoundaryNodes() to do the same thing, so that function should be used instead.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3146

    • Property Status changed from new to assigned
    • Property Component changed from General to Core : Styles
    • Property Priority changed from Normal to High
    • Property Owner set to Martin Kou
    • Property Keywords Confirmed Review? added
  • Ticket #3146 – Description

    initial v4  
    1515 * Actual Result : The link is not inserted at all.
    1616
     17'''Additional information:'''
     18This is actually a style system bug. The same thing happens if you press the bold button or try to apply any inline style with the HTML and selection above.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy