Opened 11 years ago

Closed 11 years ago

#3218 closed Bug (fixed)

sample.js is being included into the release, which makes people confused

Reported by: Frederico Caldeira Knabben Owned by: Wiktor Walc
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

The _samples/samples.js file is support file used by the development version of CKEditor. It's not needed at all after release, but it's still included in the sample files.

It must be removed during release, as well as its inclusion at the samples headers.

Attachments (1)

3218.patch (1.1 KB) - added by Wiktor Walc 11 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by Frederico Caldeira Knabben

Actually, it's not that good to have this file removed, as it handles all special alerts we have in the samples.

Part of the file code is to be removed from the distribution though. A nice comment should be also available explaining the file, telling that it can be ignored as it has nothing to do with the editor integration basics.

Changed 11 years ago by Wiktor Walc

Attachment: 3218.patch added

comment:2 Changed 11 years ago by Wiktor Walc

Keywords: Review? added

comment:3 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:4 Changed 11 years ago by Wiktor Walc

Resolution: fixed
Status: newclosed

Fixed with [3299].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy