Dialogs open out of the window

[Frederico Caldeira Knabben]

Many times, but now always, dialogs open outside the viewport, over the top of it. I has been easily reproducible with the Link dialog.

[Artur Formella]

DUP of #3258

[Frederico Caldeira Knabben]

Actually #3258 is a DUP of this one.

[Martin Kou]

Using offsetHeight and offsetWidth in CKEDITOR.dialog::getSize() doesn't work, because the browser often needs some time to layout the dialog correctly (especially to load the CSS file). That's the reason why previously getSize() would only return a size stored into resize().

Now we've changed the meaning of CKEDITOR.dialog::resize() to mean only the size of the content area, we can no longer simply output the size stored by resize() - there'll be some difference between the content area size and the whole dialog's size. The only place in the code that knows clearly the size of decorations put around the dialog content area is the skin. So I've added a 'getSize' event to CKEDITOR.dialog which must be handled by skin.js of any skin.

[Frederico Caldeira Knabben]

I understand you point here Martin, but this is a design flaw in the dialog system. It should be able to automatically detect the dialog size, without any (non accurate) help from the skin files.

If all we need is giving time the browser to "think" before moving the dialog, then a different solution can be found, which would not require skin hacks. I'm attaching a new patch for it.

[Frederico Caldeira Knabben]

Fixed with [3342].