Opened 9 years ago

Closed 9 years ago

#3345 closed Bug (fixed)

Edit anchor problem

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Firefox Review+ Cc:

Description (last modified by Garry Yao)

Reproducing Procedures

  1. Open the replace by class example page;
  2. Make the following content with selection by double click on the anchor;
    ^<a name="name"></a>^
    
  1. Click on 'Link' to open dialog, switch to 'Advanced' tab;
    • Expected Result: 'Name' filed is updated with the value 'name';
    • Actual Result: Anchor properties is not updated.

Attachments (2)

3345.patch (617 bytes) - added by Garry Yao 9 years ago.
3345_2.patch (1.7 KB) - added by Garry Yao 9 years ago.

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by Garry Yao

Attachment: 3345.patch added

comment:1 Changed 9 years ago by Garry Yao

Description: modified (diff)
Keywords: Review? added
Status: newassigned

comment:2 Changed 9 years ago by Frederico Caldeira Knabben

This issue also happens in the anchor dialog. The name doesn't get load. It worked for me when creating an anchor in the middle of the text, but not when having an empty document.

comment:3 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

That "enlarge" call may be required by the link dialog system. I think the fix should be different, by calling getSelectedElement first, and them trying to enlarge if it returns nothing. Also, the fix must also go to the anchor dialog (first of all).

Changed 9 years ago by Garry Yao

Attachment: 3345_2.patch added

comment:4 Changed 9 years ago by Garry Yao

Keywords: Review? added; Review- removed

L68-L80 of codes in plugins\link\dialogs\anchor.js are ported from v2, where back in that time we may possibly has text content in anchor node, but v3 will not have that case, so the anchor element detection logic could be further simplified.

comment:5 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:6 Changed 9 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3340]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy