Opened 8 years ago

Last modified 7 years ago

#3360 assigned Bug

Enlarge range by element problem

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone:
Component: General Version: 3.0
Keywords: HasPatch Cc:

Description

When enlarging a block element with element unit, the enlargement will climb up to any ancestor block, which is wrong.

Attachments (2)

test_range_enlarge_element_td_data.patch (3.7 KB) - added by Garry Yao 8 years ago.
Unit Test Case
3306.patch (2.5 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by Garry Yao

Unit Test Case

comment:1 Changed 8 years ago by Garry Yao

Enlarge a cell content as in the TC from the following:

<table><tr><td>^cell^</td></tr></table>

would result in the whole table been within the range:

^<table><tr><td>cell</td></tr></table>^

This is wrong because the enlargement doesn't respect the selection.

Changed 8 years ago by Garry Yao

Attachment: 3306.patch added

comment:2 Changed 8 years ago by Garry Yao

The proposed patch limit the enlargement to the selection range root, prevent it from climbing up.

comment:3 Changed 8 years ago by Garry Yao

Keywords: HasPatch added

comment:4 Changed 8 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.0CKEditor 3.x

Can you bring us a practical example of this issue?

comment:6 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

comment:7 Changed 7 years ago by Wiktor Walc

Version: 3.0
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy