Ticket #3360 (assigned Bug)

Opened 5 years ago

Last modified 3 years ago

Enlarge range by element problem

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone:
Component: General Version: 3.0
Keywords: HasPatch Cc:

Description

When enlarging a block element with element unit, the enlargement will climb up to any ancestor block, which is wrong.

Attachments

test_range_enlarge_element_td_data.patch (3.7 KB) - added by garry.yao 5 years ago.
Unit Test Case
3306.patch (2.5 KB) - added by garry.yao 5 years ago.

Change History

Changed 5 years ago by garry.yao

Unit Test Case

comment:1 Changed 5 years ago by garry.yao

Enlarge a cell content as in the TC from the following:

<table><tr><td>^cell^</td></tr></table>

would result in the whole table been within the range:

^<table><tr><td>cell</td></tr></table>^

This is wrong because the enlargement doesn't respect the selection.

Changed 5 years ago by garry.yao

comment:2 Changed 5 years ago by garry.yao

The proposed patch limit the enlargement to the selection range root, prevent it from climbing up.

comment:3 Changed 5 years ago by garry.yao

  • Keywords HasPatch added

comment:4 Changed 5 years ago by garry.yao

  • Status changed from new to assigned
  • Owner set to garry.yao

comment:5 Changed 5 years ago by fredck

  • Milestone changed from CKEditor 3.0 to CKEditor 3.x

Can you bring us a practical example of this issue?

comment:6 Changed 4 years ago by fredck

  • Milestone CKEditor 3.x deleted

Milestone CKEditor 3.x deleted

comment:7 Changed 3 years ago by wwalc

  • Version set to 3.0
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy