Opened 10 years ago

Closed 10 years ago

#3380 closed Bug (fixed)

Keyboard shortcut for toolbar doesn't work in FF 2

Reported by: Damian Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: Accessibility Version:
Keywords: IBM Confirmed Review+ Cc:

Description

The keyboard shortcuts ALT+F10 and ALT+F11 do not work in FF2

Attachments (2)

3380.patch (1.9 KB) - added by Garry Yao 10 years ago.
3380_2.patch (1.6 KB) - added by Garry Yao 10 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by Artur Formella

Component: GeneralAccessibility
Keywords: Confirmed added

comment:2 Changed 10 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

Changed 10 years ago by Garry Yao

Attachment: 3380.patch added

comment:3 Changed 10 years ago by Garry Yao

Keywords: Review? added

In FF2, focus is grabbed by the editor chrome( <span id="cke_editorN"...> ) when bubbling upand it's even not possible to avoid by declaring 'useCapture', so focus events on both toolbar button/element path were prevent from bubbling manually in the patch.

comment:4 Changed 10 years ago by Garry Yao

'focus' event should not bubble at all theoritically, and it's not with either FF3 or IE, so this should belong to a FF2 bug.

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The fix is ok. But, the code in elementspath can be simplified. The browser check can be done just once, when creating the element HTML, adding the inline onfocus attribute for FF2 only. At that point, the preventBubble call can also be done inline inside the "onfocus" attribute value directly.

Changed 10 years ago by Garry Yao

Attachment: 3380_2.patch added

comment:6 Changed 10 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:7 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:8 Changed 10 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3446]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy