Opened 16 years ago
Closed 16 years ago
#3380 closed Bug (fixed)
Keyboard shortcut for toolbar doesn't work in FF 2
| Reported by: | Damian | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | Accessibility | Version: | |
| Keywords: | IBM Confirmed Review+ | Cc: |
Description
The keyboard shortcuts ALT+F10 and ALT+F11 do not work in FF2
Attachments (2)
Change History (10)
comment:1 Changed 16 years ago by
| Component: | General → Accessibility |
|---|---|
| Keywords: | Confirmed added |
comment:2 Changed 16 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → assigned |
Changed 16 years ago by
| Attachment: | 3380.patch added |
|---|
comment:3 Changed 16 years ago by
| Keywords: | Review? added |
|---|
comment:4 Changed 16 years ago by
'focus' event should not bubble at all theoritically, and it's not with either FF3 or IE, so this should belong to a FF2 bug.
comment:5 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
The fix is ok. But, the code in elementspath can be simplified. The browser check can be done just once, when creating the element HTML, adding the inline onfocus attribute for FF2 only. At that point, the preventBubble call can also be done inline inside the "onfocus" attribute value directly.
Changed 16 years ago by
| Attachment: | 3380_2.patch added |
|---|
comment:6 Changed 16 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:7 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:8 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
In FF2, focus is grabbed by the editor chrome( <span id="cke_editorN"...> ) when bubbling upand it's even not possible to avoid by declaring 'useCapture', so focus events on both toolbar button/element path were prevent from bubbling manually in the patch.