Opened 10 years ago

Closed 10 years ago

#3391 closed Bug (fixed)

Table dialog layout review

Reported by: Frederico Caldeira Knabben Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: UI : Dialogs Version:
Keywords: Confirmed IBM Review+ Cc: Damian

Description

The table dialog is the only one that goes out of our design standards, having all labels at the left of the fields instead of above them. We need uniformity here.

Attachments (2)

3391.patch (7.5 KB) - added by Garry Yao 10 years ago.
3391_2.patch (9.0 KB) - added by Frederico Caldeira Knabben 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

Changed 10 years ago by Garry Yao

Attachment: 3391.patch added

comment:2 Changed 10 years ago by Garry Yao

Keywords: Review? added

comment:3 Changed 10 years ago by Garry Yao

Beside the table layout changes, the patch also introduce two adjustment to the dialog system:

  1. Allow html as label text;
  2. Allow customized style on page element;

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
Owner: changed from Garry Yao to Frederico Caldeira Knabben
Status: assignednew

The changes are mostly ok. I'll be going a bit further, by removing superfluous code from the dialog definition, as well as trying to make it look a bit better.

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 3391_2.patch added

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed
Status: newassigned

comment:6 Changed 10 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:7 Changed 10 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [3413].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy