Opened 10 years ago

Closed 10 years ago

#3423 closed Bug (fixed)

Unable to outdent when editor.config.indentUnit != 'px'

Reported by: Josh Nisly Owned by: Martin Kou
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (CKEditor) - OLD
Keywords: HasPatch Review+ Cc:

Description

If the editor configuration is set to use an indent unit other than px (e.g. 'pt'), outdenting does not work. This is because the indent detection logic uses getComputedStyle, which returns the indent in pixels.

One solution is to mimic V2 behavior and use getStyle instead of getComputedStyle. Attached is a patch which implements this.

Attachments (1)

3423.patch (868 bytes) - added by Josh Nisly 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by Josh Nisly

Attachment: 3423.patch added

comment:1 Changed 10 years ago by Josh Nisly

Keywords: HasPatch added

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added
Owner: set to Martin Kou

Actually it makes sense having the inline style being taken, instead of its computed value. I'm calling Martin for the commit, so he can give us his opinion about it.

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.0

comment:4 Changed 10 years ago by Martin Kou

There's still the problem of the editor changing blocks with %/px/ex/... margin left styles to pt - but that's a less critical problem. This patch at least allows non-px units to be used in the indentUnit config, so it's a good improvement.

comment:5 Changed 10 years ago by Martin Kou

Resolution: fixed
Status: newclosed

Fixed with [3480].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy