Opened 9 years ago

Closed 9 years ago

#3434 closed Bug (fixed)

Replace config.autoLanguage comment with config.language in config.js.

Reported by: Martin Kou Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (CKEditor) - OLD
Keywords: Review+ Cc:

Description

The config.autoLanguage parameter is now obsolete - it's not checked anywhere by the editor's code. Instead, what we're doing right now is this:

  1. Check if there's a config.language - if it is defined, use that.
  2. Check if we have a translation matching the browser's default language - if we have, use that.
  3. If all fails, use config.defaultLanguage.

Right now the explanation in config.js, as well as some of the documentations in _source/core/lang.js, are not reflecting what's actually happening.

Attachments (3)

3434.patch (852 bytes) - added by Artur Formella 9 years ago.
3434_2.patch (882 bytes) - added by Artur Formella 9 years ago.
3434_3.patch (998 bytes) - added by Frederico Caldeira Knabben 9 years ago.

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by Artur Formella

Attachment: 3434.patch added

comment:1 Changed 9 years ago by Artur Formella

Keywords: Review? added
Owner: set to Artur Formella
Status: newassigned

comment:2 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The "language" setting is no a boolean, and it's relationship with the defaultLanguage setting is different now.

Also, I would change the sample in the config.js file, using now the "language" setting, replacing the defaultLanguage example. It looks more like a real user case in this way.

Changed 9 years ago by Artur Formella

Attachment: 3434_2.patch added

comment:3 Changed 9 years ago by Artur Formella

Keywords: Review? added; Review- removed

comment:4 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
Owner: changed from Artur Formella to Frederico Caldeira Knabben
Status: assignednew

Changed 9 years ago by Frederico Caldeira Knabben

Attachment: 3434_3.patch added

comment:5 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed

comment:6 Changed 9 years ago by Artur Formella

Keywords: Review+ added; Review? removed

comment:7 Changed 9 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: newclosed

Fixed with [3459].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy