Opened 15 years ago

Closed 15 years ago

#3450 closed Bug (fixed)

[IE] Find result highlighting problem

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: IE IBM Confirmed Review+ Cc:

Description

Previous highlight marking style is not removed when search more than twice.

Reproducing Procedures

  1. Open the replace by class example page;
  2. Open 'Find' dialog, search for 'some';
  3. Keep the dialog open, another search for 'are'
  • Actual Result: Search results from both matching are marked.

Attachments (6)

ie-find-highlight.png (25.1 KB) - added by Tobiasz Cudnik 15 years ago.
IE8 strict
ie-find-highlight-2.png (22.0 KB) - added by Tobiasz Cudnik 15 years ago.
IE8 strict
3450.patch (580 bytes) - added by Garry Yao 15 years ago.
3450_2.patch (3.3 KB) - added by Garry Yao 15 years ago.
3450_3.patch (4.6 KB) - added by Garry Yao 15 years ago.
3450_4.patch (5.1 KB) - added by Garry Yao 15 years ago.

Download all attachments as: .zip

Change History (23)

comment:1 Changed 15 years ago by Artur Formella

#3451 has been marked as DUP.

comment:2 Changed 15 years ago by Garry Yao

Resolution: fixed
Status: newclosed

Confirmed it been fixed with #3304.

comment:3 Changed 15 years ago by Martin Kou

Keywords: IBM added

Changed 15 years ago by Tobiasz Cudnik

Attachment: ie-find-highlight.png added

IE8 strict

Changed 15 years ago by Tobiasz Cudnik

Attachment: ie-find-highlight-2.png added

IE8 strict

comment:4 Changed 15 years ago by Tobiasz Cudnik

Resolution: fixed
Status: closedreopened

I'm still able to reproduce this issue. Refer to attached screenshots.

comment:5 Changed 15 years ago by Garry Yao

Keywords: Confirmed added

Changed 15 years ago by Garry Yao

Attachment: 3450.patch added

comment:6 Changed 15 years ago by Garry Yao

Keywords: Review? added

Changed 15 years ago by Garry Yao

Attachment: 3450_2.patch added

comment:7 Changed 15 years ago by Garry Yao

Proposing a more completed fix.

comment:8 Changed 15 years ago by Tobiasz Cudnik

I can confirm that 3450_2.patch works for IE8.

comment:9 Changed 15 years ago by Martin Kou

Keywords: Review- added; Review? removed

Two problems:

  1. The lowercase and semicolon fixes applied in getAttribute() are not effective.
  2. The whitespace fix in getAttribute() would break some CSS styles, e.g.
    border 1px solid red;
    

Changed 15 years ago by Garry Yao

Attachment: 3450_3.patch added

comment:10 Changed 15 years ago by Garry Yao

Keywords: Review? added; Review- removed

Remove the invalid 'white space fix' and reflect related TCs.

comment:11 Changed 15 years ago by Garry Yao

Keywords: Review? removed

Oops, style plugin changes is not included.

Changed 15 years ago by Garry Yao

Attachment: 3450_4.patch added

comment:12 Changed 15 years ago by Garry Yao

Keywords: Review? added

comment:13 Changed 15 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:14 Changed 15 years ago by Martin Kou

Owner: set to Garry Yao
Status: reopenednew

comment:15 Changed 15 years ago by Frederico Caldeira Knabben

I would avoid changes to CKEDITOR.dom.element as those are Style plugin specific.

comment:16 in reply to:  15 Changed 15 years ago by Garry Yao

Status: newassigned

Replying to fredck:

I would avoid changes to CKEDITOR.dom.element as those are Style plugin specific.

My motivation of this change is that normalize CKEDITOR.dom.element could remove many existed (even further) fixing around the style system, beside, style system's been a intrinsic component, which always loaded with core codes, I guess this fix not impacting too much of been moved into core.

comment:17 Changed 15 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3517].

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy