Opened 16 years ago
Closed 16 years ago
#3450 closed Bug (fixed)
[IE] Find result highlighting problem
| Reported by: | Garry Yao | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | General | Version: | |
| Keywords: | IE IBM Confirmed Review+ | Cc: |
Description
Previous highlight marking style is not removed when search more than twice.
Reproducing Procedures
- Open the replace by class example page;
- Open 'Find' dialog, search for 'some';
- Keep the dialog open, another search for 'are'
- Actual Result: Search results from both matching are marked.
Attachments (6)
Change History (23)
comment:1 Changed 16 years ago by
comment:2 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Confirmed it been fixed with #3304.
comment:3 Changed 16 years ago by
| Keywords: | IBM added |
|---|
comment:4 Changed 16 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
I'm still able to reproduce this issue. Refer to attached screenshots.
comment:5 Changed 16 years ago by
| Keywords: | Confirmed added |
|---|
Changed 16 years ago by
| Attachment: | 3450.patch added |
|---|
comment:6 Changed 16 years ago by
| Keywords: | Review? added |
|---|
Changed 16 years ago by
| Attachment: | 3450_2.patch added |
|---|
comment:9 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
Two problems:
- The lowercase and semicolon fixes applied in getAttribute() are not effective.
- The whitespace fix in getAttribute() would break some CSS styles, e.g.
border 1px solid red;
Changed 16 years ago by
| Attachment: | 3450_3.patch added |
|---|
comment:10 Changed 16 years ago by
| Keywords: | Review? added; Review- removed |
|---|
Remove the invalid 'white space fix' and reflect related TCs.
comment:11 Changed 16 years ago by
| Keywords: | Review? removed |
|---|
Oops, style plugin changes is not included.
Changed 16 years ago by
| Attachment: | 3450_4.patch added |
|---|
comment:12 Changed 16 years ago by
| Keywords: | Review? added |
|---|
comment:13 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:14 Changed 16 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | reopened → new |
comment:15 follow-up: 16 Changed 16 years ago by
I would avoid changes to CKEDITOR.dom.element as those are Style plugin specific.
comment:16 Changed 16 years ago by
| Status: | new → assigned |
|---|
Replying to fredck:
I would avoid changes to CKEDITOR.dom.element as those are Style plugin specific.
My motivation of this change is that normalize CKEDITOR.dom.element could remove many existed (even further) fixing around the style system, beside, style system's been a intrinsic component, which always loaded with core codes, I guess this fix not impacting too much of been moved into core.
#3451 has been marked as DUP.