Opened 16 years ago
Closed 16 years ago
#3455 closed Bug (fixed)
Fixed color palette in colour selectors should provide names for colors
Reported by: | Damian | Owned by: | Martin Kou |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | Accessibility | Version: | |
Keywords: | IBM Review+ | Cc: |
Description
The fixed color selector palettes displayed for font color and background color should provide names for those colors. This is to allow JAWS to read meaningful names instead of numbers.
Attachments (3)
Change History (12)
comment:1 Changed 16 years ago by
Owner: | set to Martin Kou |
---|---|
Status: | new → assigned |
Changed 16 years ago by
Attachment: | 3455.patch added |
---|
comment:2 Changed 16 years ago by
Keywords: | Review? added |
---|
comment:3 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
It's a very good color table. The colors have been very well positioned.
comment:4 Changed 16 years ago by
Keywords: | Review- added; Review+ removed |
---|
Those are entries that change in each language, so they should be translated instead of hardcoded in the config.
Changed 16 years ago by
Attachment: | 3455_2.patch added |
---|
comment:5 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:6 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
What about having a more compact solution at this point?
In the language file:
colors : { '000' : 'Black', '800000' : 'Maroon', ... }
Also, this entry doesn't need to go inside the colorButton object. It's quite generic, and could be used anywhere, so it's ok to have it in the root.
Then, the configuration can stay in the same format as it was previously (with the new colors of course).
Changed 16 years ago by
Attachment: | 3455_3.patch added |
---|
comment:7 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:8 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:9 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed with [3460].
Click here for more info about our SVN system.
The color list is changed to use selected colors from W3C's HTML color list.