Opened 15 years ago
Closed 13 years ago
#3457 closed New Feature (fixed)
There is no way to add textarea content
Reported by: | Artur Formella | Owned by: | Alfonso Martínez de Lizarrondo |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.2 |
Component: | UI : Dialogs | Version: | |
Keywords: | Cc: | Sa'ar Zac Elias, Garry Yao, damn man |
Description
There is no way to change the textarea content in WYSIWYG mode (actually in FF, IE and Opera. In Webkit is buggy).
It should be possible in textarea dialog.
Attachments (5)
Change History (19)
comment:1 Changed 15 years ago by
Keywords: | Confirmed added |
---|---|
Milestone: | CKEditor 3.x → CKEditor 3.1 |
comment:2 Changed 15 years ago by
Milestone: | CKEditor 3.1 → CKEditor 3.x |
---|
comment:3 Changed 14 years ago by
Cc: | Sa'ar Zac Elias Garry Yao added |
---|
comment:6 Changed 13 years ago by
Owner: | set to Alfonso Martínez de Lizarrondo |
---|---|
Status: | confirmed → review |
The patch rearranges the cols & rows field to use just one row in the dialog and adds a textarea below to set the value.
Changed 13 years ago by
Attachment: | 3457_patch_-_FF4_Screenshot.png added |
---|
comment:7 Changed 13 years ago by
Status: | review → review_failed |
---|
The dialog is prety much broken for me, after patch.
comment:8 Changed 13 years ago by
Status: | review_failed → review |
---|
comment:9 Changed 13 years ago by
Status: | review → review_passed |
---|
While the dialog layout is ok/acceptable, I've written some basic dt tests for this in t/3457:
http://ckeditor.t/dt/plugins/forms/textarea.html
Some tests are not passing.
While the tests may be related to things that are already present in the editor, by introducing the value field it makes too easy to identify the problems, so I think it's a good time to have them fixed as well.
comment:11 Changed 13 years ago by
Ok, I've updated the tests and we have in fact just problems with <textarea> data. The following cases:
<textarea>Line 1 Line 2</textarea> <textarea> Spaces before.</textarea> <textarea>Spaces after. </textarea>
Both line breaks and extra spaces get lost.
As said earlier, as the field is now available, it's pretty easy to set textarea data and these issues will come to the eyes immediately, especially the line breaks issue. Therefore, better to get it fixed as well.
comment:12 Changed 13 years ago by
Status: | review_failed → review |
---|
The testcase shows that new lines at the start are respected only by Opera, all the other browsers ignore them. Besides that, IE (tested just 8) also ignores new lines at the end. Fixing those issues seems too complex as it's just the innerHTML property the one that fails there.
The patch adjust the htmlParser\fragment.js to try to respect the whitespace just like done in PREs
comment:13 Changed 13 years ago by
Milestone: | → CKEditor 3.6.2 |
---|---|
Status: | review → review_passed |
Patches 2+3 look pretty good now. All tests passing.
comment:14 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [7236]
#5748 and #5295 have been marked as dups