Changes between Initial Version and Version 1 of Ticket #349


Ignore:
Timestamp:
Apr 10, 2007, 11:42:28 AM (18 years ago)
Author:
Frederico Caldeira Knabben
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #349 – Description

    initial v1  
    1 Hello,i'am a developer from China,and it's very thankful that you give
    2 > us so perfect editor.But in my development with it i found some
    3 > functions may not work as what we want.
    4 > When i use the editor(2.4.1) in Maxthon (2.0) Browser,i open the image dialog
    5 > and click the "Browse Server" Button,then the new window opend as a
    6 > new tab in the browser while the image dialog still show on the top of
    7 > the browser,which i have to close it if i want to choose some files in
    8 > the opend browse server window.
    9 >
    10 > Here is the way i change the function to solve this bug,hoping to give
    11 > some suggestion to you:
    12 >
    13 > /FckEditor/Editor/dialog/common/fck_dialog_common.js
    14 >
    15 > function OpenFileBrowser (...)
    16 > {
    17 > ..
    18 > //at the bottom of the function
    19 >  if(oEditor.FCKBrowserInfo.IsIE)
    20 >         {
    21 >             window.showModalDialog(url+"&rdm="+new
    22 > Date(),window,"status:false;dialogWidth:"+width+"px;dialogHeig
    23 > ht:"+height+"px\"");
    24 >         }
    25 >         else
    26 >         {
    27 >             window.open( url, 'FCKBrowseWindow', sOptions ) ;
    28 >         }
    29 > }
    30 >
    31 > Of course we should change the place where works with this
    32 > function,such as:
    33 > fckeditor\editor\filemanager\browser\default\frmresourceslist.html
    34 >
    35 > function OpenFile( fileUrl )
    36 > {
    37 >     if( window.dialogArguments)
    38 >     {
    39 >         window.dialogArguments.SetUrl( fileUrl ) ;
    40 >         window.close() ;
    41 >           window.dialogArguments.focus() ;
    42 >       }
    43 >       else
    44 >       {       
    45 >           window.top.opener.SetUrl( fileUrl ) ;
    46 >           window.top.close() ;
    47 >           window.top.opener.focus() ;
    48 >       }
    49 > }
    50 Also,we need to modify the function which recieves the folder name when we Create New Folder for the method "prompt" does'nt work in  dialog mode.
    51 >
    52 > As this,our editor now work normal in browser no matter it bases on IE
    53 > or FireFox
     1Hello,
     2
     3I'm a developer from China,and it's very thankful that you give us so perfect editor.But in my development with it i found some functions may not work as what we want. When i use the editor(2.4.1) in Maxthon (2.0) Browser,i open the image dialog  and click the "Browse Server" Button,then the new window opened as a new tab in the browser while the image dialog still show on the top of the browser,which i have to close it if i want to choose some files in the opened browse server window.
     4
     5Here is the way i change the function to solve this bug,hoping to give some suggestion to you:
     6
     7/editor/dialog/common/fck_dialog_common.js
     8{{{
     9function OpenFileBrowser (...)
     10{
     11..
     12//at the bottom of the function
     13 if(oEditor.FCKBrowserInfo.IsIE)
     14        {
     15            window.showModalDialog(url+"&rdm="+new
     16Date(),window,"status:false;dialogWidth:"+width+"px;dialogHeig
     17ht:"+height+"px\"");
     18        }
     19        else
     20        {
     21            window.open( url, 'FCKBrowseWindow', sOptions ) ;
     22        }
     23}
     24}}}
     25
     26Of course we should change the place where works with this
     27function,such as:
     28
     29editor/filemanager/browser/default/frmresourceslist.html
     30{{{
     31function OpenFile( fileUrl )
     32{
     33    if( window.dialogArguments)
     34    {
     35        window.dialogArguments.SetUrl( fileUrl ) ;
     36        window.close() ;
     37            window.dialogArguments.focus() ;
     38        }
     39        else
     40        {       
     41            window.top.opener.SetUrl( fileUrl ) ;
     42            window.top.close() ;
     43            window.top.opener.focus() ;
     44        }
     45}
     46}}}
     47
     48Also,we need to modify the function which receives the folder name when we Create New Folder for the method "prompt" doesn't work in  dialog mode.
     49
     50As this,our editor now work normal in browser no matter it bases on IE or FireFox.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy