Opened 13 years ago

Closed 12 years ago

#349 closed Bug (fixed)

[FCKeditor Site] About "OpenFileBrowse" Function's bug in Maxthon browser

Reported by: wang.seraph Owned by:
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version:
Keywords: Cc:

Description (last modified by Frederico Caldeira Knabben)

Hello,

I'm a developer from China,and it's very thankful that you give us so perfect editor.But in my development with it i found some functions may not work as what we want. When i use the editor(2.4.1) in Maxthon (2.0) Browser,i open the image dialog and click the "Browse Server" Button,then the new window opened as a new tab in the browser while the image dialog still show on the top of the browser,which i have to close it if i want to choose some files in the opened browse server window.

Here is the way i change the function to solve this bug,hoping to give some suggestion to you:

/editor/dialog/common/fck_dialog_common.js

function OpenFileBrowser (...)
{
..
//at the bottom of the function
 if(oEditor.FCKBrowserInfo.IsIE)
        {
            window.showModalDialog(url+"&rdm="+new
Date(),window,"status:false;dialogWidth:"+width+"px;dialogHeig
ht:"+height+"px\"");
        }
        else
        {
            window.open( url, 'FCKBrowseWindow', sOptions ) ;
        }
}

Of course we should change the place where works with this function,such as:

editor/filemanager/browser/default/frmresourceslist.html

function OpenFile( fileUrl )
{
    if( window.dialogArguments)
    {
        window.dialogArguments.SetUrl( fileUrl ) ;
        window.close() ;
	    window.dialogArguments.focus() ;
	}
	else
	{	
	    window.top.opener.SetUrl( fileUrl ) ;
	    window.top.close() ;
	    window.top.opener.focus() ;	
	}
}

Also,we need to modify the function which receives the folder name when we Create New Folder for the method "prompt" doesn't work in dialog mode.

As this,our editor now work normal in browser no matter it bases on IE or FireFox.

Change History (3)

comment:1 Changed 13 years ago by Frederico Caldeira Knabben

Description: modified (diff)

comment:2 Changed 13 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 3.0

comment:3 Changed 12 years ago by Alfonso Martínez de Lizarrondo

Milestone: FCKeditor 3.0FCKeditor 2.6
Resolution: fixed
Status: newclosed

The new dialog system from #35 has fixed this problem, the server browse window gets the focus properly.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy