Opened 16 years ago
Closed 16 years ago
#3609 closed Bug (fixed)
Parser fixbody option should align with enterMode
Reported by: | Garry Yao | Owned by: | Tobiasz Cudnik |
---|---|---|---|
Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 3.0 |
Component: | General | Version: | |
Keywords: | Review+ | Cc: |
Description
Any form of paragraph wrapping should respect the enterMode option:
Reproducing Procedures
- Open the replace by class example page with enterMode set to 'div' , initial with the following content:
fixBody
- Switch to wysiwyg mode and switch back;
- Actual Result : Source codes now as :
<p> fixBody</p>
- Expected Result :
<div> fixBody</div>
- Actual Result : Source codes now as :
Attachments (3)
Change History (16)
comment:1 Changed 16 years ago by
Owner: | set to Tobiasz Cudnik |
---|
comment:2 Changed 16 years ago by
Status: | new → assigned |
---|
Changed 16 years ago by
Attachment: | 3609.patch added |
---|
comment:3 Changed 16 years ago by
Keywords: | Review? added |
---|
comment:4 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
The patch works but I think it's not necessary to guard on fixForBody variable, all of it's usages were explicitly defined as either 'div','p', OR 'false'.
Changed 16 years ago by
Attachment: | 3609_2.patch added |
---|
comment:5 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:6 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:8 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Changed 16 years ago by
Attachment: | 3609_3.patch added |
---|
comment:9 Changed 16 years ago by
Keywords: | Review? added; Review+ removed |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
We've left another spot unfixed for 'fixForBody'.
comment:10 Changed 16 years ago by
Priority: | Normal → High |
---|
comment:11 Changed 16 years ago by
After checking Garry patch and couple of functionalities which are related to the changed code, everything seems to work well. The change will just ensure that in any case getData will return fixed content. It shouldn't have negative impact in any way.
comment:12 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
Patch allows to set custom fixForBody for htmlparser/fragment.js, which is then used by wysiwygarea plugin.