Opened 10 years ago

Closed 10 years ago

#3609 closed Bug (fixed)

Parser fixbody option should align with enterMode

Reported by: Garry Yao Owned by: Tobiasz Cudnik
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: Review+ Cc:

Description

Any form of paragraph wrapping should respect the enterMode option:

Reproducing Procedures

  1. Open the replace by class example page with enterMode set to 'div' , initial with the following content:
    fixBody
    
  2. Switch to wysiwyg mode and switch back;
    • Actual Result : Source codes now as :
       <p>
      	fixBody</p>
      
    • Expected Result :
        <div>
      	  fixBody</div>
      

Attachments (3)

3609.patch (1.9 KB) - added by Tobiasz Cudnik 10 years ago.
3609_2.patch (2.3 KB) - added by Tobiasz Cudnik 10 years ago.
3609_3.patch (1.3 KB) - added by Garry Yao 10 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Owner: set to Tobiasz Cudnik

comment:2 Changed 10 years ago by Tobiasz Cudnik

Status: newassigned

Changed 10 years ago by Tobiasz Cudnik

Attachment: 3609.patch added

comment:3 Changed 10 years ago by Tobiasz Cudnik

Keywords: Review? added

Patch allows to set custom fixForBody for htmlparser/fragment.js, which is then used by wysiwygarea plugin.

comment:4 Changed 10 years ago by Garry Yao

Keywords: Review- added; Review? removed

The patch works but I think it's not necessary to guard on fixForBody variable, all of it's usages were explicitly defined as either 'div','p', OR 'false'.

Changed 10 years ago by Tobiasz Cudnik

Attachment: 3609_2.patch added

comment:5 Changed 10 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

comment:6 Changed 10 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:7 Changed 10 years ago by Tobiasz Cudnik

Fixed with [3642].

comment:8 Changed 10 years ago by Tobiasz Cudnik

Resolution: fixed
Status: assignedclosed

Changed 10 years ago by Garry Yao

Attachment: 3609_3.patch added

comment:9 Changed 10 years ago by Garry Yao

Keywords: Review? added; Review+ removed
Resolution: fixed
Status: closedreopened

We've left another spot unfixed for 'fixForBody'.

comment:10 Changed 10 years ago by Garry Yao

Priority: NormalHigh

comment:11 Changed 10 years ago by Tobiasz Cudnik

After checking Garry patch and couple of functionalities which are related to the changed code, everything seems to work well. The change will just ensure that in any case getData will return fixed content. It shouldn't have negative impact in any way.

comment:12 Changed 10 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:13 Changed 10 years ago by Garry Yao

Resolution: fixed
Status: reopenedclosed

Fixed with [3663].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy