Opened 10 years ago

Closed 10 years ago

#3621 closed Task (fixed)

Unnecessary snapshots

Reported by: Artur Formella Owned by: Artur Formella
Priority: Normal Milestone: CKEditor 3.0
Component: Core : Undo & Redo Version:
Keywords: Confirmed Review+ Cc:

Description

Now we're saving snapshot for many commands which doesn't make sense for supporting undo, these are:

  1. Preview
  2. Copy
  3. Spell Check
  4. Find/Replace ( Each replacing is needing one, but not the dialog command )
  5. Select All
  6. Maximize
  7. Show Block
  8. About

We should give them a canUndo = false.

Attachments (2)

3621.patch (4.1 KB) - added by Artur Formella 10 years ago.
3621_2.patch (3.8 KB) - added by Artur Formella 10 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added
Owner: set to Artur Formella

I'm just not sure about Spell Check. We must be sure we can undo a spell checking change after closing the dialog.

Changed 10 years ago by Artur Formella

Attachment: 3621.patch added

comment:2 Changed 10 years ago by Artur Formella

Keywords: Review? added
  1. We can't undo Print command

comment:3 Changed 10 years ago by Garry Yao

Keywords: Review- added; Review? removed

Why not declare:

CKEDITOR.plugins.print =
{
        ...
        modes : { wysiwyg : !( CKEDITOR.env.opera ) }           // It is imposible to print the inner document in Opera.
        canUndo : false
};

Instead of doing:

  var command = editor.addCommand( pluginName, CKEDITOR.plugins.print ); 
  command.canUndo = false;

Changed 10 years ago by Artur Formella

Attachment: 3621_2.patch added

comment:4 Changed 10 years ago by Artur Formella

Keywords: Review? added; Review- removed

You are right.

comment:5 Changed 10 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:6 Changed 10 years ago by Artur Formella

Resolution: fixed
Status: newclosed

Fixed with [3608]

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy