Opened 15 years ago
Closed 15 years ago
#3621 closed Task (fixed)
Unnecessary snapshots
Reported by: | Artur Formella | Owned by: | Artur Formella |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | Core : Undo & Redo | Version: | |
Keywords: | Confirmed Review+ | Cc: |
Description
Now we're saving snapshot for many commands which doesn't make sense for supporting undo, these are:
- Preview
- Copy
- Spell Check
- Find/Replace ( Each replacing is needing one, but not the dialog command )
- Select All
- Maximize
- Show Block
- About
We should give them a canUndo = false.
Attachments (2)
Change History (8)
comment:1 Changed 15 years ago by
Keywords: | Confirmed added |
---|---|
Owner: | set to Artur Formella |
Changed 15 years ago by
Attachment: | 3621.patch added |
---|
comment:3 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
Why not declare:
CKEDITOR.plugins.print = { ... modes : { wysiwyg : !( CKEDITOR.env.opera ) } // It is imposible to print the inner document in Opera. canUndo : false };
Instead of doing:
var command = editor.addCommand( pluginName, CKEDITOR.plugins.print ); command.canUndo = false;
Changed 15 years ago by
Attachment: | 3621_2.patch added |
---|
comment:5 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
I'm just not sure about Spell Check. We must be sure we can undo a spell checking change after closing the dialog.