Opened 10 years ago

Closed 10 years ago

#3681 closed Bug (fixed)

[Webkit] Shift enter broken

Reported by: Garry Yao Owned by: Garry Yao
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: Webkit Confirmed Review+ Cc:

Description (last modified by Garry Yao)

Reproducing Procedures

  1. Open the replace by class example page in FF;
  2. Move cursor inside the text, and press 'Shift-Enter';
    • Expected Result: Link break introduced with cursor blinking in front of next paragraph, and If you continue to press this keystroke many times until the the content is outside viewport, latest linebreak will also be scrolled into view;
    • Actual Result: The cursor is still at the end of the first paragraph.

Attachments (1)

3681.patch (2.3 KB) - added by Garry Yao 10 years ago.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Garry Yao

Attachment: 3681.patch added

comment:1 Changed 10 years ago by Garry Yao

Keywords: Review? added
Status: newassigned

Several fixes in this patch:

  1. Fixing a logic error where bogus BR is not guaranteed in webkit when shift enter.
  2. The dummy node for hacking scroll into view function should have some content inside;
  3. Another defensive logic error within CKDITOR.dom.element::getDocumentPosition.

comment:2 Changed 10 years ago by Garry Yao

Description: modified (diff)
Priority: NormalHigh

Adding necessary 'Expected Result' regard auto scrolling into view.

comment:3 Changed 10 years ago by Martin Kou

Keywords: Review+ added; Review? removed

The patch also affects Opera, but it doesn't seem to have any adverse effect there. Review+

comment:4 Changed 10 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3630].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy