Ticket #3697 (closed Task: fixed)

Opened 5 years ago

Last modified 4 years ago

CKLangTool should be launched automatically before releasing

Reported by: wwalc Owned by: wwalc
Priority: Normal Milestone: CKEditor 3.1
Component: Project : CKPackager Version:
Keywords: Confirmed Review+ Cc:

Description

the title says it all - in patches usually just the "en" language entry is added and this way CKEditor is broken in all other languages.

Attachments

3697_cklangtool.patch (1.1 KB) - added by wwalc 4 years ago.
3697_ckreleaser.patch (1.4 KB) - added by wwalc 4 years ago.
3697_ckeditor.patch (1.9 KB) - added by wwalc 4 years ago.

Change History

comment:1 Changed 5 years ago by fredck

  • Milestone changed from CKEditor 3.0 to CKEditor 3.1

Changed 4 years ago by wwalc

Changed 4 years ago by wwalc

Changed 4 years ago by wwalc

comment:2 Changed 4 years ago by wwalc

  • Keywords Review? added

Basically, the idea is to allow to inject extra scripts to be executed by CKReleaser at some point (by adding extra argument --run-before-release=). We're adding here an option to execute extra code straight after files are copied to the release folder, before the real release process starts (minification etc.).

In the future we may use similar trick for example before files compression (before making zip/tar.gz files) or at any other point.

In release.bat, we're instructing CKReleaser to execute langtool.bat. CKLangTool is instructed to process files inside of the "release" directory, so the source code above _dev/releaser folder is not touched.

There are some minor modifications in CKLangTool to properly instruct CKReleaser when error occurs (errors are now printed to stderr, not to stdout).

comment:3 Changed 4 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:4 Changed 4 years ago by wwalc

  • Status changed from new to closed
  • Resolution set to fixed

Fixed with [4591] (CKLangTool), [4592] (CKReleaser), [4593] (CKEditor).

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy