Opened 16 years ago
Closed 15 years ago
#3697 closed Task (fixed)
CKLangTool should be launched automatically before releasing
| Reported by: | Wiktor Walc | Owned by: | Wiktor Walc |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | Project : CKPackager | Version: | |
| Keywords: | Confirmed Review+ | Cc: |
Description
the title says it all - in patches usually just the "en" language entry is added and this way CKEditor is broken in all other languages.
Attachments (3)
Change History (7)
comment:1 Changed 16 years ago by
| Milestone: | CKEditor 3.0 → CKEditor 3.1 |
|---|
Changed 15 years ago by
| Attachment: | 3697_cklangtool.patch added |
|---|
Changed 15 years ago by
| Attachment: | 3697_ckreleaser.patch added |
|---|
Changed 15 years ago by
| Attachment: | 3697_ckeditor.patch added |
|---|
comment:2 Changed 15 years ago by
| Keywords: | Review? added |
|---|
comment:3 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:4 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Basically, the idea is to allow to inject extra scripts to be executed by CKReleaser at some point (by adding extra argument
--run-before-release=). We're adding here an option to execute extra code straight after files are copied to the release folder, before the real release process starts (minification etc.).In the future we may use similar trick for example before files compression (before making zip/tar.gz files) or at any other point.
In release.bat, we're instructing CKReleaser to execute langtool.bat. CKLangTool is instructed to process files inside of the "release" directory, so the source code above _dev/releaser folder is not touched.
There are some minor modifications in CKLangTool to properly instruct CKReleaser when error occurs (errors are now printed to stderr, not to stdout).